Display additional tax total in order - fixes #11680

[abdulazizali77]

What? Why?

• Closes [Admin->Orders] Include tax on fees in the line item adjustment table #11680
  The admin/orders#edit form doesnt display additional tax adjustments

UNCERTAIN

• Label for the Tax category order adjustment which is currently 'Tax category'

What should we test?

• Add new Product with price $10
• Add non-included Tax Rate with 13%
• Add Enterprise Fee with Tax category of the newly added Tax Rate with Flat Percent (per item) of 20%
• Add the newly added Enterprise Fee to the Order Cycle with the new Product
• Create new Order adding 1 Product. The final checkout price will be $13.56 with (included tax) of $0.26

Tax included in price
Same scenario as above but with Tax Rate included in the price. Check it's working as before.

Release notes

Changelog Category (reviewers may add a label for the release notes):

• User facing changes
• API changes (V0, V1, DFC or Webhook)
• Technical changes only
• Feature toggled

The title of the pull request will be included in the release notes.

[sigmundpetersen]

Hi @abdulazizali77 👋 I see this is still a draft PR.
Do you want to move forward with this one?

[abdulazizali77]

@sigmundpetersen apologies for the delay, PTAL and review.
As noted in the notes above, uncertain about using I18n.t("tax_category"), as label.
Additionally the spec file might not be completely optimal

[rioug]

Thanks for your help @abdulazizali77 🙏 !
The PR looks fine, but there are a couple things I would like you to change, see my comments.
The spec is fine, we could probably achieve the same with a per_item enterprise fee but no need to change that.
I don't think we need to cover the tax included in the price here, but just to be sure I updated the test note so our testers can double check that.

[rioug]

Almost there, we need a better name for the translatable text.

NOTE for the future, once a PR has been reviewed it's best not to force push on the branch as we loose the commit history, and it can make it hard for other reviewer to follow what happened.

[filipefurtad0]

Hey @abdulazizali77 ,

I've verified that indeed taxes over enterprise fees are not appearing on the order edit page, for our both tax types (included / added):

• added tax

• included tax

After this PR, we can see that the tax over the enterprise fee is appearing correctly - however, this is only the case, when the tax is is inclided to the enterprise fee:

• added tax - applied tax is missing

• included tax - OK, applied tax is visible on a separate parcel

I'd say let's merge this PR. This is much more critical when the tax is added, as it leads to wrong totals. So, I'm not actually even sure we need this to work for inclued tax...

In anycase and for now: merging!