Add task to check for invalid address #12413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It checks for invalid addresses, ie address with address1, city, phone or country_id set to null. It will return: - a list of invalid address in use (associated to another model) - a list of invalid address not in use, ie that we can delete
rioug
added
the
technical changes only
mkllnk
approved these changes
Apr 24, 2024
Sounds like a good idea to me. I think that we'd do the same thing manually before the release (eg manually copy the code to each affected server, then run it, then construct a delete statement.) |
dacook
requested changes
Apr 24, 2024
Comment on lines
65
to
67
| next e.address_id if check_correct_address_id(e.address_id, invalid_addresses) | ||
|
|
||
| e.business_address_id if check_correct_address_id(e.business_address_id, invalid_addresses) |
There was a problem hiding this comment.
Is it possible that an Enterprise has both invalid address and business_address?
Comment on lines
92
to
94
| next o.ship_address_id if check_correct_address_id(o.ship_address_id, addresses) | ||
|
|
||
| o.bill_address_id if check_correct_address_id(o.bill_address_id, addresses) |
There was a problem hiding this comment.
As above, I think we could miss invalid addresses here.
Seems a bit risky, as an alternative I can printout the code to be run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
As part of #12407, we added some migration that tighten the data validation at the database level, in particular for addresses.
These migrations will fail deployment of the database contains invalid data.
This task check for invalid data addresses and check if they are in use, ie linked to another model. It will return :
Example output :
What should we test?
Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.