Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let Rubocop suggest extensions #12371

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

mkllnk
Copy link
Member

@mkllnk mkllnk commented Apr 12, 2024

What? Why?

We are using all suggested extensions already and it's not suggesting anything at the moment. Using the default value for suggesting extensions will mean that Rubocop will tell us when there's a new recommended extension for our code base.

What should we test?

  • No test.

Release notes

Changelog Category (reviewers may add a label for the release notes):

  • User facing changes
  • API changes (V0, V1, DFC or Webhook)
  • Technical changes only
  • Feature toggled

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

We are using all suggested extensions already and it's not suggesting
anything at the moment. Using the default value for suggesting
extensions will mean that Rubocop will tell us when there's a new
recommended extension for our code base.
@mkllnk mkllnk self-assigned this Apr 12, 2024
@mkllnk mkllnk added the technical changes only These pull requests do not contain user facing changes and are grouped in release notes label Apr 12, 2024
@mkllnk mkllnk marked this pull request as ready for review April 12, 2024 02:39
@rioug rioug merged commit 4de1905 into openfoodfoundation:master Apr 15, 2024
52 checks passed
@mkllnk mkllnk deleted the suggest-rubocop-extensions branch May 8, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical changes only These pull requests do not contain user facing changes and are grouped in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants