Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Lint/DuplicateRequire issue #12344

Merged

Conversation

cyrillefr
Copy link
Contributor

What? Why?

Fixes one of many rubocop issues:

  • cop class: RuboCop::Cop::Lint::DuplicateRequire
  • that is: some requires are made twice
  • .rubocop_todo.yml updated

What should we test?

Nothing: this is all about syntax linting and how rubocop should raise no offenses on the above cop when checking.

Release notes

Changelog Category (reviewers may add a label for the release notes):

  • User facing changes
  • API changes (V0, V1, DFC or Webhook)
  • Technical changes only
  • Feature toggled

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

 - updates the todo list
@cyrillefr
Copy link
Contributor Author

Hello @sigmundpetersen or @dacook ,

I would need another check run. some unexpected error showed up.

@sigmundpetersen
Copy link
Contributor

Green now @cyrillefr 👍

Copy link
Collaborator

@rioug rioug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too easy 😆 !

@rioug rioug merged commit 3634032 into openfoodfoundation:master Apr 8, 2024
50 checks passed
@cyrillefr cyrillefr deleted the FixLintDuplicateRequireIssue branch April 9, 2024 07:54
@mkllnk mkllnk added the technical changes only These pull requests do not contain user facing changes and are grouped in release notes label Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical changes only These pull requests do not contain user facing changes and are grouped in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants