-
-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUU] Style and behaviour updates #12107
Conversation
Now it's lined up perfectly with the number input.
Using browser validation. I didn't use model validation because the on_hand pseudo-attribute doesn't support it. But.. it turned out to not be so simple. Browser validation can't work if the field is hidden, and breaks the javascript. So now I made the javascript smarter, and the end result is more helpful I think.
It's not usually valid, but can still be entered. I wasn't able to fix the positioning of the :after psuedo element without having a child text node. Maybe it's possible to add an empty child text node, but I didn't think it worth getting down to that level..
FYI @mariocarabotta I've created these fixes, can you please let me know if you see any problems? |
good stuff David! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Easy to follow. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done !
looking good, merging! |
What? Why?
Just some little updates that have popped up. Plus I added a few more..
Now, it just appears blank. We'll probably adjust minimum widths later as part of a broader change.
Columns with inputs should now line up. Well.. almost. The On Hand popout has reduced padding which messes it up a bit, but I won't dwell on that right now.
What should we test?
As above.
Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates