Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify default hash tabs controller to redirect users to shopping panel when an OC is selected. #12103

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Modify default hash tabs controller to redirect users to shopping panel when an OC is selected. #12103

merged 1 commit into from
Feb 19, 2024

Conversation

basilawwad
Copy link
Contributor

@basilawwad basilawwad commented Jan 30, 2024 •
edited
Loading

What? Why?

The activateDefaultPanel function takes the user to the default page, when a home_panel is added, it is set as the default page instead of the shop_panel.

What should we test?

see #12076

@basilawwad basilawwad marked this pull request as draft January 30, 2024 09:43
@basilawwad basilawwad force-pushed the selecting-OC-should-redirect-to-shop branch from 93909d7 to b7e1ed8 Compare February 9, 2024 09:58
@basilawwad
added shop target and activateshoppanel function
08111f9 
Remove Pending Message

Update shopping_spec.rb

Update shopping_spec.rb
@basilawwad basilawwad force-pushed the selecting-OC-should-redirect-to-shop branch from 2ea5f9a to 08111f9 Compare February 16, 2024 06:31
@basilawwad basilawwad marked this pull request as ready for review February 16, 2024 06:37
mkllnk
mkllnk approved these changes Feb 18, 2024
View reviewed changes
Copy link
Member

@mkllnk mkllnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

rioug
rioug approved these changes Feb 18, 2024
View reviewed changes
Copy link
Collaborator

@rioug rioug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help ! looks good 👍

@mkllnk
Copy link
Member

mkllnk commented Feb 18, 2024

@rioug I'm moving this to Test Ready on the Github board as well. New process! Good bye Zenhub.

@drummer83 drummer83 self-assigned this Feb 19, 2024
@drummer83 drummer83 added no-staging-AU A tag which does not trigger deployments, indicating a server is being used no-staging-UK A tag which does not trigger deployments, indicating a server is being used no-staging-FR A tag which does not trigger deployments, indicating a server is being used pr-staged-au staging.openfoodnetwork.org.au pr-staged-uk staging.openfoodnetwork.org.uk pr-staged-fr staging.coopcircuits.fr and removed no-staging-UK A tag which does not trigger deployments, indicating a server is being used no-staging-FR A tag which does not trigger deployments, indicating a server is being used no-staging-AU A tag which does not trigger deployments, indicating a server is being used pr-staged-uk staging.openfoodnetwork.org.uk pr-staged-fr staging.coopcircuits.fr labels Feb 19, 2024
@drummer83
Copy link
Contributor

Hi @basilawwad,
Thanks for working on this one!

I have tested it on our staging server and it's looking good!

I can confirm that

  • when changing the shop through the /shops page, the user is still redirected to the home page. ✔️
  • as soon as the user selects an order cycle, they get redirected to the shop page. ✔️
  • when selecting a different order cycle, the user gets redirected to the shop page as well. ✔️
  • also when visiting other tabs - like 'Contact' - the user gets redirected to the shop page when changing the order cycle. ✔️

I can't think of much more to test here, actually.

We're good to go!
Merging! 🚀 🎉

Thanks again!

@drummer83 drummer83 merged commit 2477a63 into openfoodfoundation:master Feb 19, 2024
62 checks passed
@drummer83 drummer83 removed the pr-staged-au staging.openfoodnetwork.org.au label Feb 19, 2024
@mkllnk mkllnk added the user facing changes Thes pull requests affect the user experience label Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkllnk mkllnk mkllnk approved these changes

@rioug rioug rioug approved these changes

Assignees

@drummer83 drummer83

@basilawwad basilawwad

Labels
user facing changes Thes pull requests affect the user experience
Projects
OFN Delivery board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Selecting OC redirects to shop's home page
4 participants
@basilawwad @mkllnk @drummer83 @rioug