-
-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify default hash tabs controller to redirect users to shopping panel when an OC is selected. #12103
Modify default hash tabs controller to redirect users to shopping panel when an OC is selected. #12103
Conversation
93909d7
to
b7e1ed8
Compare
Remove Pending Message Update shopping_spec.rb Update shopping_spec.rb
2ea5f9a
to
08111f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your help ! looks good 👍
@rioug I'm moving this to Test Ready on the Github board as well. New process! Good bye Zenhub. |
Hi @basilawwad, I have tested it on our staging server and it's looking good! I can confirm that
I can't think of much more to test here, actually. We're good to go! Thanks again! |
What? Why?
The activateDefaultPanel function takes the user to the default page, when a home_panel is added, it is set as the default page instead of the shop_panel.
What should we test?
see #12076