Tests app/services/stripe_payment_status.rb #11963
Conversation
|
This PR seems to interfere with other VCR tapes, I'll move this back to In Dev till this is clarified. |
filipefurtad0
added
the
technical changes only
filipefurtad0
force-pushed
the
stripe_payment_status_spec_vcr
branch
from
36e5aba
to
265de61
Compare
| @@ -162,6 +162,9 @@ | |||
| vcr_config.default_cassette_options = { record: :none } if ENV["CI"] | |||
| end | |||
| example.run | |||
| VCR.configure do |vcr_config| | |||
| vcr_config.cassette_library_dir = "spec/fixtures/vcr_cassettes" | |||
| end | |||
There was a problem hiding this comment.
It seems VCR was looking for a cassette in the Stripe folder, although this one is not related to Stripe:
VCR is currently using the following cassette:
- /home/runner/work/openfoodnetwork/openfoodnetwork/spec/fixtures/vcr_cassettes/Stripe-v10.3.0/ConnectAppJob/stores_connection_data_on_the_app.yml
Somehow, the around block on base spec helper is not really resetting the VCR configs. This change might just do it, but I'm not sure there isn't a better way.
There was a problem hiding this comment.
This makes sense: we are setting a different config value, and need to re-set it back after the example is completed. This would be relevant for the other config change too (default_cassette_options).
I couldn't find a built-in method for achieving this, so would be tempted to build one..
For now, I'd suggest saving the current vcr_config before example.run, then applying it again after.
I've pushed a new commit to demonstrate, let me know what you think.
I couldn't find a built-in way to do it, and couldn't even directly access the vcr config outside of VCR.configure. So this is the best way I could think of.
| @@ -162,6 +162,9 @@ | |||
| vcr_config.default_cassette_options = { record: :none } if ENV["CI"] | |||
| end | |||
| example.run | |||
| VCR.configure do |vcr_config| | |||
| vcr_config.cassette_library_dir = "spec/fixtures/vcr_cassettes" | |||
| end | |||
There was a problem hiding this comment.
This makes sense: we are setting a different config value, and need to re-set it back after the example is completed. This would be relevant for the other config change too (default_cassette_options).
I couldn't find a built-in method for achieving this, so would be tempted to build one..
For now, I'd suggest saving the current vcr_config before example.run, then applying it again after.
I've pushed a new commit to demonstrate, let me know what you think.
| preferred_enterprise_id: create(:enterprise).id) | ||
| } | ||
|
|
||
| before { Stripe.api_key = secret } |
There was a problem hiding this comment.
I was going to suggest that we should reset the api key back after the end of the test. But then I realised that this key is the only key that would be used during tests, so we might as well set it once in envrionment config.
Then I realised we already do, in STRIPE_INSTANCE_SECRET_KEY. Do you know why we set the test key in a special STRIPE_SECRET_TEST_API_KEY?
What? Why?
Related to Epic #11890.
Closes #11962
Tests
app/services/stripe_payment_status.rbby replacingreceive_message_chainRspec mocks with responses from VCR calls.What should we test?
Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates