-
-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump rubocop from 1.58.0 to 1.59.0 #11933
Conversation
Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.58.0 to 1.59.0. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.58.0...v1.59.0) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1519 files inspected, 45 offenses detected, 28 offenses autocorrectable
I'll regenerate the todo file.
After regenerating the todo file, Rails/OutputSafety is still coming up.
They seem to be false positives though:
It thinks that I did a git bisect to find the culprit and found it: @dacook Your rule is great but it overrides the todo file. Cop settings are stored in a hash and each key can be present once only. So |
Oh, how unfortunate. Maybe we could move my rule to the todo file? Hmm no, then when we regenerate it, it will replace the rule. Maybe we should fix all the Rails/OutputSafety todos? They're probably all valid uses, and just need a rubocop:disable comment. I can try after lunch if you like. |
The tag generator methods should already be returning html_safe strings.
These all seem to require html_safe/raw, so we'll permit it. Some of the spree code is a bit strange and could probably be improved, but I think it's ok for now.
This one is a little more concerning: what if a model error message includes the user-submitted value? But this is for the admin interface only, and I'm not sure if we have model error messages that do that. So it's probably fine (it's certainly been like this a long time already).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work.
I keep wondering if some of these could have been written in a better way. But we don't need to add to our list at the moment.
And in the end, this now means that you are not allowed to add any violations of this cop to the todo list. You have to solve it or add a comment in the code. I'm happy with that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to see some clean up of the todo list 🧹
Bumps rubocop from 1.58.0 to 1.59.0.
Release notes
Sourced from rubocop's releases.
Changelog
Sourced from rubocop's changelog.
Commits
e5a164a
Cut 1.592912b6e
Update Changelog3bcc171
[Fix #12524] Fix a false positive forStyle/MethodCallWithArgsParentheses
0daa4aa
MakeStyle/MethodCallWithoutArgsParentheses
allow parenthesizedit
b240a09
MakeStyle/RedundantSelf
allowself.it
a0e1042
[Fix #12526] Fix incorrect rendering typosb1bcb31
[Fix #12444] Fix false positive forStyle/HashEachMethods
3b0360b
Add newLint/ItWithoutArgumentsInBlock
cop4e9cfcc
Merge pull request #12521 from koic/make_style_select_by_regexp_aware_of_safe...037c860
Merge pull request #12438 from koic/fix_a_false_positive_for_lint_literal_ass...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)