-
-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaces Stripe Stubs with VCR calls #11924
Replaces Stripe Stubs with VCR calls #11924
Conversation
Adds new VCR cassettes Keeps assertion on ActiverMerchant response Re-records cassettes
0684204
to
b45fc0b
Compare
I have to admit I don't know how to deal with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for working through this is making our tests check the real-world responses! 💪
I have a couple of queries, and a suggestion for tidying up.
Fixes typo on capture_amount declaration
b259185
to
0f41d90
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this code is good now, but I'll also request a review from Maikel, as he has been discussing this with you.
Replaces stubs on VCR cassettes. We do this here for the file
./spec/models/spree/gateway/stripe_sca_spec.rb
.What? Why?
Instead of asserting on our DB we can callStripe::PaymentIntent.retrieve
to actually be sure that the Stripe paymentchanges status, by running our code 🎉-> rookie optimism :-)Edit:
we canwe'll just do the above and assert on the ActiveMerchant response...What should we test?
Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates