[BUU] Link style tweaks #11907
Merged
[BUU] Link style tweaks #11907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code was from Spree. Unless you have good focus/active styles for all links, the outline is very helpful for accessibility. Most websites these days add nice thick outlines, which might be worth considering in the future.
It looks really wierd when there's only a few items.
And thus avoid wrapping inside the li. This avoids the menu going off the edge of the screen.
dacook
added
pr-no-test
technical changes only
|
Merging without review, due to very minimal changes, behind a feature toggle. |
|
@dacook I'm removing the staging-AU label. Hope that's ok. 🙏 |
|
Yes, thanks I forgot sorry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
See commit messages.