product should not be priceless

[abdellani]

What? Why?

• Closes Priceless product registration #11862

What should we test?

4 things:

1. create a product with price = blank using 'create' button
2. create a product with price = blank using 'create and add another' button
3. try to set the variant price to blank and click on 'update',
4. after step 3, you should see the error messages (before this PR, it was not working)
5. try cloning products
6. try importing products

Release notes

Changelog Category (reviewers may add a label for the release notes):

• User facing changes
• API changes (V0, V1, DFC or Webhook)
• Technical changes only
• Feature toggled

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

[drummer83]

@abdellani I know this is still work in progress but I need to ask one question: Will this PR prevent having any products/variants with price = 0?

@openfoodfoundation/train-drivers-product-owners I think there are use cases for free products, like some giveaways or whatever.

[abdellani]

Will this PR prevent having any products/variants with price = 0?

that's what I understood from the issue description.

I don't think it'll make sense to prevent creating a product with a price=0, without preventing the variant's price from being 0.
In the end, the product's price will be stored on the variant that will be created automatically.

[RachL]

@abdellani I've just reproduced it and the problem in shopfronts happens when price is empty, not when price is equal to 0. Can we prevent empty prices and keep prices = to 0 ?

Basically it's about having prices as mandatory fields.

[mkllnk]

Good solution. I guess, as alternative, we could have added a presence validation on prices. But this should work for now as well.

[rioug]

Good one 👍

[filipefurtad0]

Hey @abdellani ,

Thanks for this fix 💪

I've tested in staging-UK with the localization option enabled (as described in this comment):

It introduces a validation on /admin/products/new:
(verified with both buttons Create and Create and add another)

• Updating an existing product to have an empty price:

• Saving a cloned product to have an empty price:

• importing a product with empty price info
  

• importing a product with 0.0 as price

Other scenarios were also verified to allow for zero priced products.

As a quick double check disabled the localization option, which seems to not trigger the bug: all good as expected.

Merging!
Thanks 🎉

[dacook]

I see that 'technical changes only' was ticked, but the label hasn't been applied. I think this is a user-facing bug so will leave it unlabelled (therefore "user-facing changes").