Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec refactor #11853

Conversation

dacook
Copy link
Member

@dacook dacook commented Nov 24, 2023

What should we test?

  • specs pass

Release notes

Changelog Category (reviewers may add a label for the release notes):

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

And remove unnecessary button click.
@dacook dacook added the technical changes only These pull requests do not contain user facing changes and are grouped in release notes label Nov 24, 2023
Copy link
Member

@mkllnk mkllnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

@filipefurtad0 filipefurtad0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting! It's good to know we can extract information page elements this way...
Thanks for improving this @dacook 🙏

@filipefurtad0 filipefurtad0 merged commit 92686c9 into openfoodfoundation:master Nov 24, 2023
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical changes only These pull requests do not contain user facing changes and are grouped in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants