Avoid precompiling assets unnecessarily #11847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helper file is only loaded when system specs are loaded. So we don't need to check for the absence of system specs because this file wouldn't be loaded if there were not system specs to be run.
We had two calls to precompile assets, one for all specs and then a second one just for system specs. The one for system specs is better because it checks for the webpack dev server before compiling assets. So let's use just that one.
mkllnk
changed the title
mkllnk
added
the
technical changes only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
We had two calls to pre-compile assets. One for all specs and one for system specs only. So assets got compiled for lib specs which don't need it and they were compiled twice for system specs.
I removed the duplication and added some logic to compile assets only for specs that need it.
What should we test?
public/packs-test/was deleted.Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates