Fix hidden input showing on Producer registration #11776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks some CSS we use is breaking the use of "hidden"
rioug
changed the title
|
Yikes 😬 True and false appearing indeed!...
Ok, after this PR, it is fixed:
Thanks for spotting this one @rioug , and fixing it 💪 |
filipefurtad0
merged commit 8a3fbf9
into
openfoodfoundation:master
51 of 52 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSS defined in
node_modules/foundation-sites/scss/foundation/components/_forms.scssbreaks the use ofhiddenon a<input>tag with no specifiedtypeWhat? Why?
Set the input type to hidden so it's actually hidden
What should we test?
See step to reproduce in #11775
Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.