Maintain date range values in the report forms

[yasirazgar]

What? Why?

• Closes [Reports] Customers report doesn't keep the date range selection #11612

Date range selection needs to maintained after form submission

What should we test?

• Visit ... page.
  Date range should be maintained after form submission
• http://localhost:3000/admin/reports/packing
• http://localhost:3000/admin/reports/customers

customer.mov

customer.pack.mov

Release notes

Changelog Category (reviewers may add a label for the release notes):

• User facing changes
• API changes (V0, V1, DFC or Webhook)
• Technical changes only
• Feature toggled

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

[rioug]

Nice one ! Thanks for your help 🙏

[mkllnk]

Thank you, this is great!

[mkllnk]

Hashes have a nice fail-safe method to access values that may be there:

Suggested change

	- start_date ||= params[:q].try(:[], :completed_at_gt)
	- end_date ||= params[:q].try(:[], :completed_at_lt)
	- start_date ||= params.dig(:q, :completed_at_gt)
	- end_date ||= params.dig(:q], :completed_at_lt)

[drummer83]

Hi @yasirazgar,
Thank you so much for this pull request and sorry for the slow testing process!

I have staged your PR to one of our servers an compared before and after. I found that before staging the Customers report as well as the Enterprise Fee Summary report were not keeping the date selection. All other reports did.

Before staging

Customers report after clicking 'Go':

Enterprise Fee Summary report after clicking 'Go':

After staging

Customers report after clicking 'Go':

Enterprise Fee Summary report after clicking 'Go':

We can see that the date selection is now kept. 💪

I have also checked that

• all other report are still keeping the date range,
• reloading the report clears the date range (and all other settings),
• no errors are logged in Bugsnag.

Results

Excellent! I couldn't find any issue with this pull request! 🥳
I will go ahead and merge this one! 🚀

Thanks again!