🚧 BUU: some design updates + one small code fix #11401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jibees
changed the title
jibees
changed the title
Not sure this is the best solution, since it's not exactly the right usage of tom-select
Still need to wrap/ellipsis selected item...
jibees
force-pushed
the
some-buu-design-updates
branch
from
29fa4ed
to
f4a6bec
Compare
dacook
approved these changes
Aug 16, 2023
Comment on lines
+117
to
+122
| display: grid; | ||
| grid-template-columns: repeat(6, 1fr); | ||
| grid-template-rows: 1fr; | ||
| grid-column-gap: 20px; | ||
| align-items: end; | ||
| margin-bottom: 20px; |
There was a problem hiding this comment.
I think we might have had this conversation before, but I can't remember:
I find the grid syntax not as clear for what it is doing. I think I prefer the old style of using classes like .two.columns , but admit that is limited. This is probably good, I just need to get more familiar with it :)
|
|
||
| input { | ||
| &::placeholder { | ||
| color: $light-grey; |
There was a problem hiding this comment.
I noticed this was barely readable
| @@ -4,10 +4,10 @@ | |||
| = text_field_tag :search_term, search_term, placeholder: t('.search_products') | |||
| .producers | |||
| .label= t('.producers.label') | |||
| = select_tag :producer_id, options_for_select(producer_options, producer_id), include_blank: t('.all_producers') | |||
| = select_tag :producer_id, options_for_select(producer_options, producer_id), include_blank: t('.all_producers'), "data-controller": "tom-select", "data-tom-select-options-value": '{ "plugins": [] }', class: "fullwidth" | |||
There was a problem hiding this comment.
Perhaps we want to make a tom_select_tag helper, with predefined options for "single", etc. We can style it with a class.
|
This is behind a WIP feature toggle, and doesn't solve any outcomes that need testing, so I'll merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Follow-up #11007
Separate WIP in this branch to several PRs.
What should we test?
Release notes
Changelog Category: Technical changes
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates