-
-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚧 BUU: some design updates + one small code fix #11401
🚧 BUU: some design updates + one small code fix #11401
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good !
Not sure this is the best solution, since it's not exactly the right usage of tom-select
Still need to wrap/ellipsis selected item...
29fa4ed
to
f4a6bec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for now 👍
display: grid; | ||
grid-template-columns: repeat(6, 1fr); | ||
grid-template-rows: 1fr; | ||
grid-column-gap: 20px; | ||
align-items: end; | ||
margin-bottom: 20px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we might have had this conversation before, but I can't remember:
I find the grid syntax not as clear for what it is doing. I think I prefer the old style of using classes like .two.columns
, but admit that is limited. This is probably good, I just need to get more familiar with it :)
|
||
input { | ||
&::placeholder { | ||
color: $light-grey; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed this was barely readable
@@ -4,10 +4,10 @@ | |||
= text_field_tag :search_term, search_term, placeholder: t('.search_products') | |||
.producers | |||
.label= t('.producers.label') | |||
= select_tag :producer_id, options_for_select(producer_options, producer_id), include_blank: t('.all_producers') | |||
= select_tag :producer_id, options_for_select(producer_options, producer_id), include_blank: t('.all_producers'), "data-controller": "tom-select", "data-tom-select-options-value": '{ "plugins": [] }', class: "fullwidth" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we want to make a tom_select_tag
helper, with predefined options for "single", etc. We can style it with a class.
This is behind a WIP feature toggle, and doesn't solve any outcomes that need testing, so I'll merge now. |
What? Why?
Follow-up #11007
Separate WIP in this branch to several PRs.
What should we test?
Release notes
Changelog Category: Technical changes
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates