Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 Remove new_products_page and all associated controllers/components/... #11382

Merged
merged 1 commit into from
Aug 11, 2023
Merged

🔧 Remove new_products_page and all associated controllers/components/... #11382

merged 1 commit into from
Aug 11, 2023

Conversation

jibees
Copy link
Contributor

@jibees jibees commented Aug 10, 2023

👑 new_products_page is dead, long live admin_style_v3 ! 👸

What? Why?

What should we test?

  • You should not be able to activate new_products_page feature toggle
  • Automatic specs and release testing should be enough

Release notes

Changelog Category: Technical changes

@jibees jibees self-assigned this Aug 10, 2023
@jibees jibees changed the title 🔧 Remove new_products_page and all associated controller/components/... 🔧 Remove new_products_page and all associated controllers/components/... Aug 10, 2023
@jibees
Remove new_products_page and all associated controller/components/
3b68674 
new_products_page` is dead, long live `admin_style_v3` !
@jibees jibees force-pushed the 11273-buu-remove-new_products_page-feature-toggle branch from 86292fe to 3b68674 Compare August 10, 2023 08:02
mkllnk
mkllnk approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@mkllnk mkllnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good cleanup.

rioug
rioug approved these changes Aug 11, 2023
View reviewed changes
Copy link
Collaborator

@rioug rioug left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit sad to see code that hasn't made it to production being discarded, anyway nice cleaning !

@jibees jibees requested a review from dacook August 11, 2023 07:06
@jibees
Copy link
Contributor Author

jibees commented Aug 11, 2023

Just added @dacook as a reviewer so he knows

dacook
dacook approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@dacook dacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sad, but yes I approve :)

@RachL RachL added the pr-staged-fr staging.coopcircuits.fr label Aug 11, 2023
@RachL
Copy link
Contributor

RachL commented Aug 11, 2023

Seems to work! merging

@RachL RachL merged commit 5afe45d into openfoodfoundation:master Aug 11, 2023
52 checks passed
@RachL RachL removed the pr-staged-fr staging.coopcircuits.fr label Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkllnk mkllnk mkllnk approved these changes

@dacook dacook dacook approved these changes

@rioug rioug rioug approved these changes

Assignees

@jibees jibees

Labels
None yet
Projects
OFN Delivery board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUU] Remove new_products_page feature toggle
5 participants
@jibees @RachL @mkllnk @dacook @rioug