-
-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix display invoice tab for completed, resumed and canceled orders only #11327
Fix display invoice tab for completed, resumed and canceled orders only #11327
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 , Thanks for that !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
States tested:
I wonder if we shouldn't leave the tab for the awaiting return state... Or to simplify any state equal or future to complete? Will ask our order states masters, but it does not block this PR. Merging! |
What? Why?
Closes #11240
Show invoice tab if the invoice feature is enabled for the current user
Also adding method in the Order model that checks the state of the order, and using it in the edit page to fix the display of the invoice tab
What should we test?
Change the state of the orders and check if the invoice tab is displayed for
completed
,resumed
andcanceled
onlyRelease notes
Changelog Category: Technical changes
The title of the pull request will be included in the release notes.