Fix display invoice tab for completed, resumed and canceled orders only #11327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdellani
reviewed
Aug 3, 2023
abdellani
reviewed
Aug 3, 2023
abdellani
reviewed
Aug 3, 2023
abdellani
reviewed
Aug 3, 2023
rioug
approved these changes
Aug 7, 2023
|
States tested:
I wonder if we shouldn't leave the tab for the awaiting return state... Or to simplify any state equal or future to complete? Will ask our order states masters, but it does not block this PR. Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Closes #11240
Show invoice tab if the invoice feature is enabled for the current user
Also adding method in the Order model that checks the state of the order, and using it in the edit page to fix the display of the invoice tab
What should we test?
Change the state of the orders and check if the invoice tab is displayed for
completed,resumedandcanceledonlyRelease notes
Changelog Category: Technical changes
The title of the pull request will be included in the release notes.