Skip online domain validation of dev user email #11321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We improved the email address validation to check the domain for existing DNS entries. But our default user has the example.com domain which is not resolved by my internet service provider. I couldn't find a better way to deactivate this one check than overriding the method in the validator. The code does not affect other parts of the app unless you run multiple rake tasks in the same command line with the database setup.
The `<<` operation saves the association already.
mkllnk
commented
Aug 3, 2023
| @@ -58,10 +58,13 @@ def create_admin_user | |||
| admin = Spree::User.new(attributes) | |||
| admin.skip_confirmation! | |||
| admin.skip_confirmation_notification! | |||
|
|
|||
| # The default domain example.com is not resolved by all nameservers. | |||
| ValidEmail2::Address.define_method(:valid_mx?) { true } | |||
There was a problem hiding this comment.
The alternative would be a new attribute on the User model to skip mx domain validation. But I decided to avoid it as long as we don't have other use cases because it would be more code in a much used class.
abdellani
approved these changes
Aug 3, 2023
|
No test required, merging. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Whenever I ran
rails db:resetthe default test user couldn't be created because my internet service provider doesn't resolve the example.com domain. Skipping the validation solves this.What should we test?
Release notes
Changelog Category: Technical changes
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates