-
-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix margin in guest checkout #11302
fix margin in guest checkout #11302
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CSS change looks good. A screenshot would have been helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you and welcome!
I took a look into this because I noticed that this CSS affects both the logged-in and guest views, but the issue says the problem is only on guest.
I discovered that the HTML for logged-in view is using our grid css classes (eg parent row
and small-12 columns
), and the guest view intends to but is broken (it's missing a parent row
and the columns
class).
Would you be able to have a go at fixing it that way instead? This would improve the layout on larger screens also.
0021d64
to
addbbc4
Compare
I used the same logic like in logged in checkout form, i wanted the use the classes in the edit template but i don't want to mess the divs of the stimulus tatgets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, thank you!
It will now be checked by a tester before merging. @drummer83 would you like to pick this up?
Hi @bouaik, Before staging the PR
After staging the PR
Excellent work! This is ready for merging! 🚀 🥳 |
What? Why?
What should we test?
As per issue.
Release notes
Changelog Category: Technical changes
(DC: I chose technical because the change shouldn't have any effect on users other than looking slightly different)
The title of the pull request will be included in the release notes.