Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin: improve platform version displaying on admin homepage #11292

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Admin: improve platform version displaying on admin homepage #11292

merged 1 commit into from
Jul 28, 2023

Conversation

jibees
Copy link
Contributor

@jibees jibees commented Jul 27, 2023 •
edited
Loading

What? Why?

with multi enterprises manager
Capture d’écran 2023-07-27 à 15 41 15
with single enterprise manager
Capture d’écran 2023-07-27 à 15 41 24

What should we test?

  • As a multi enterprises manager, check that version is correctly displayed on the backoffice homepage
  • As a single enterprise manager, check that version is correctly displayed on the backoffice homepage

Release notes

Changelog Category: User facing changes

@jibees jibees self-assigned this Jul 27, 2023
mkllnk
mkllnk approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@mkllnk mkllnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@filipefurtad0 filipefurtad0 self-assigned this Jul 28, 2023
@filipefurtad0 filipefurtad0 added the pr-staged-uk staging.openfoodnetwork.org.uk label Jul 28, 2023
@filipefurtad0
Copy link
Contributor

Hey @jibees,

I've looked at the scenarios you point out:

  • multi-enterprise manager

image

  • with single enterprise manager

image

image

Looks good to ship!
Thanks.

@filipefurtad0 filipefurtad0 merged commit 2169067 into openfoodfoundation:master Jul 28, 2023
52 checks passed
@filipefurtad0 filipefurtad0 removed the pr-staged-uk staging.openfoodnetwork.org.uk label Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkllnk mkllnk mkllnk approved these changes

Assignees

@jibees jibees

@filipefurtad0 filipefurtad0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Dashboard, Supplier profile] Inconsistent indentation on deployed version
3 participants
@jibees @filipefurtad0 @mkllnk