Fix swagger-api integration after last update #11278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkllnk
commented
Jul 26, 2023
Comment on lines
+5
to
+20
| describe "API documentation", type: :request do | ||
| it "shows the OFN API v1" do | ||
| get rswag_ui_path | ||
| expect(response).to redirect_to "/api-docs/index.html" | ||
|
|
||
| get "/api-docs/index.html" | ||
| expect(response).to have_http_status :success | ||
|
|
||
| expect(response.body).to match "API V1" | ||
| end | ||
|
|
||
| it "can load the Swagger config" do | ||
| get "/api-docs/v1/swagger.yaml" | ||
| expect(response).to have_http_status :success | ||
| end | ||
| end |
There was a problem hiding this comment.
This is an integration test with an external component. So it's not meant to be complete or particularly sophisticated. I just reproduced the error we had. It would have been simpler in a system spec but they are slow. I didn't want to add the overhead if we can run this in "0.1276 seconds" and it's still very simple.
|
Hey @mkllnk , Cool,
Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
The API docs are broken since we updated the rswag-api gem.
See also:
What should we test?
/api-docsRelease notes
Changelog Category: Technical changes
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates