-
-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix swagger-api integration after last update #11278
Conversation
describe "API documentation", type: :request do | ||
it "shows the OFN API v1" do | ||
get rswag_ui_path | ||
expect(response).to redirect_to "/api-docs/index.html" | ||
|
||
get "/api-docs/index.html" | ||
expect(response).to have_http_status :success | ||
|
||
expect(response.body).to match "API V1" | ||
end | ||
|
||
it "can load the Swagger config" do | ||
get "/api-docs/v1/swagger.yaml" | ||
expect(response).to have_http_status :success | ||
end | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an integration test with an external component. So it's not meant to be complete or particularly sophisticated. I just reproduced the error we had. It would have been simpler in a system spec but they are slow. I didn't want to add the overhead if we can run this in "0.1276 seconds" and it's still very simple.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Crystal clear! 👌
Hey @mkllnk , Cool, Merging. |
What? Why?
The API docs are broken since we updated the rswag-api gem.
See also:
What should we test?
/api-docs
Release notes
Changelog Category: Technical changes
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates