Fix Rubocop Layout violations - 2 #11261

macanudo527 · 2023-07-21T14:34:09Z

What? Why?

Part of Fix important RuboCop issues #6055

This fixes 5 more rubocop rules that are violated in our codebase. It was generated automatically with the rubocop-autocorrect.sh script.

What should we test?

No testing required since these are safe corrections

Release notes

Changelog Category: Technical changes

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

Inspecting 1478 files ...................................................................................................................................................C.......................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C......................................................................................................................................................................................................................................................C......................CC....................C...................................................... Offenses: app/controllers/spree/users_controller.rb:53:19: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line. message: t('devise.user_registrations.spree_user.signed_up_but_unconfirmed') }) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/controllers/spree/users_controller.rb:53:101: C: Layout/LineLength: Line is too long. [107/100] message: t('devise.user_registrations.spree_user.signed_up_but_unconfirmed') }) ^^^^^^^ spec/models/enterprise_spec.rb:906:1: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line. permissions: [permission]) ^^^^^^^^^^^^^^^^^^^^^^^^^ spec/system/admin/customers_spec.rb:19:1: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line. code: nil, created_manually: true) ^^^^^^^^^ spec/system/admin/order_spec.rb:708:1: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line. distributors: [distributor1]) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/system/admin/orders_spec.rb:45:4: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line. distributors: [distributor4, distributor5]) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/system/admin/orders_spec.rb:249:9: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line. line_items_count: 0) ^^^^^^^^^^^^^^^^^^^ spec/system/admin/orders_spec.rb:254:9: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line. line_items_count: 1) ^^^^^^^^^^^^^^^^^^^ spec/system/admin/orders_spec.rb:259:9: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line. distributor: distributor2, bill_address_id: nil, ship_address_id: nil) ^^^^^^^^^^^^^^^^^^^^^^^^^ spec/system/admin/orders_spec.rb:259:101: C: Layout/LineLength: Line is too long. [109/100] distributor: distributor2, bill_address_id: nil, ship_address_id: nil) ^^^^^^^^^ spec/system/admin/tag_rules_spec.rb:145:37: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line. count: 4 ^^^^^^^^ 1478 files inspected, 11 offenses detected, 9 offenses corrected

Inspecting 1478 files .....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C.C.......C...................................................................... Offenses: spec/system/admin/order_cycles/complex_updating_specific_time_spec.rb:84:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. "#order_cycle_incoming_exchange_1_variants_#{initial_variants.last.id}" ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/system/admin/order_cycles/simple_spec.rb:784:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. "order_cycle_selected_distributor_payment_method_ids_#{distributor_payment_method_id}" ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/system/admin/order_cycles/simple_spec.rb:791:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. "order_cycle_selected_distributor_shipping_method_ids_#{distributor_shipping_method_id}" ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/system/admin/product_import_spec.rb:818:15: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. I18n.t("admin.product_import.product_headings.#{heading}").upcase ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 1478 files inspected, 4 offenses detected, 4 offenses corrected

Inspecting 1478 files ............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C......................................................................................... Offenses: spec/system/admin/enterprises_spec.rb:204:5: C: [Corrected] Layout/LeadingCommentSpace: Missing space after #. #using "find" as fields outside of the screen and are not visible ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 1478 files inspected, 1 offense detected, 1 offense corrected

Inspecting 1478 files ...................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C.....................C............................................................................ Offenses: spec/system/admin/enterprise_fees_spec.rb:52:46: C: [Corrected] Layout/LineContinuationSpacing: Use one space in front of backslash. fill_in "#{prefix}_calculator_attributes"\ ^ spec/system/admin/enterprise_fees_spec.rb:57:58: C: [Corrected] Layout/LineContinuationSpacing: Use one space in front of backslash. expect(page).to have_selector("##{prefix}_calculator"\ ^ spec/system/admin/enterprise_fees_spec.rb:142:43: C: [Corrected] Layout/LineContinuationSpacing: Use one space in front of backslash. "#{prefix}_calculator_attributes_"\ ^ spec/system/admin/order_spec.rb:646:84: C: [Corrected] Layout/LineContinuationSpacing: Use one space in front of backslash. accept_alert "An invoice for this order will be sent to the customer. "\ ^ 1478 files inspected, 4 offenses detected, 4 offenses corrected

Inspecting 1478 files .......C............................C..............................................................................................................C.......................................................................................................C............................................................................C................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C.................C......................................C...................................................................................................................C...........................................................C........................C...C.....C..C..C..........C..................C...............C.....................C...................................................................................C......................................................C........C..C...........C....................C.CC....C....................................C......C.......................... Offenses: app/components/confirm_modal_component.rb:4:88: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. def initialize(id:, confirm_actions: nil, reflex: nil, controller: nil, message: nil, ^ app/components/confirm_modal_component.rb:4:101: C: [Corrected] Layout/LineLength: Line is too long. [110/100] def initialize(id:, confirm_actions: nil, reflex: nil, controller: nil, message: nil, confirm_reflexes: nil) ^^^^^^^^^^ app/components/confirm_modal_component.rb:5:1: C: [Corrected] Layout/ParameterAlignment: Align the parameters of a method definition if they span more than one line. confirm_reflexes: nil) ^^^^^^^^^^^^^^^^^^^^^ app/controllers/admin/product_import_controller.rb:142:43: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. redirect_to '/admin/product_import', ^ app/controllers/admin/product_import_controller.rb:142:101: C: [Corrected] Layout/LineLength: Line is too long. [104/100] redirect_to '/admin/product_import', notice: I18n.t(:product_import_no_data_in_spreadsheet_notice) ^^^^ app/controllers/admin/product_import_controller.rb:143:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line. notice: I18n.t(:product_import_no_data_in_spreadsheet_notice) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/controllers/spree/users_controller.rb:53:101: C: Layout/LineLength: Line is too long. [107/100] message: t('devise.user_registrations.spree_user.signed_up_but_unconfirmed') }) ^^^^^^^ app/models/customer.rb:43:101: C: [Corrected] Layout/LineLength: Line is too long. [113/100] scope :managed_by, ->(user) { user&.persisted? ? where(user: user).or(of(Enterprise.managed_by(user))) : none } ^^^^^^^^^^^^^ app/models/customer.rb:44:1: C: [Corrected] Layout/IndentationWidth: Use 2 (not 1) spaces for indentation. user&.persisted? ? where(user: user).or(of(Enterprise.managed_by(user))) : none ^ app/models/customer.rb:44:3: C: [Corrected] Layout/IndentationWidth: Use 2 (not -19) spaces for indentation. user&.persisted? ? where(user: user).or(of(Enterprise.managed_by(user))) : none ^^^^^^^^^^^^^^^^^^^ app/models/customer.rb:44:82: C: [Corrected] Layout/BlockEndNewline: Expression at 44, 82 should be on its own line. user&.persisted? ? where(user: user).or(of(Enterprise.managed_by(user))) : none } ^ app/models/customer.rb:44:101: C: Layout/LineLength: Line is too long. [102/100] user&.persisted? ? where(user: user).or(of(Enterprise.managed_by(user))) : none ^^ app/models/customer.rb:45:1: C: [Corrected] Layout/BlockAlignment: } at 45, 0 is not aligned with ->(user) { at 43, 21 or scope :managed_by, ->(user) { at 43, 2. } ^ app/models/spree/line_item.rb:53:101: C: Layout/LineLength: Line is too long. [110/100] attr_accessor :skip_stock_check, :target_shipment # Allows manual skipping of Stock::AvailabilityValidator ^^^^^^^^^^ spec/controllers/admin/order_cycles_controller_spec.rb:38:101: C: Layout/LineLength: Line is too long. [108/100] it "loads order cycles that closed within the past month, and orders without a close_at date" do ^^^^^^^^ spec/controllers/admin/order_cycles_controller_spec.rb:48:101: C: Layout/LineLength: Line is too long. [111/100] it "loads order cycles that closed after the specified date, and orders without a close_at date" do ^^^^^^^^^^^ spec/controllers/admin/order_cycles_controller_spec.rb:100:101: C: Layout/LineLength: Line is too long. [125/100] expect(flash[:error]).to eq "You don't have permission to create an order cycle coordinated by that enterprise" ^^^^^^^^^^^^^^^^^^^^^^^^^ spec/controllers/admin/order_cycles_controller_spec.rb:125:101: C: Layout/LineLength: Line is too long. [101/100] order_cycle.exchanges.create! sender: distributor, receiver: distributor, incoming: true, ^ spec/controllers/admin/order_cycles_controller_spec.rb:127:101: C: Layout/LineLength: Line is too long. [102/100] order_cycle.exchanges.create! sender: distributor, receiver: distributor, incoming: false, ^^ spec/controllers/admin/order_cycles_controller_spec.rb:284:101: C: Layout/LineLength: Line is too long. [101/100] merge(order_cycle: { preferred_product_selection_from_coordinator_inventory_only: true }) ^ spec/controllers/admin/order_cycles_controller_spec.rb:311:101: C: Layout/LineLength: Line is too long. [104/100] create(:exchange, order_cycle: order_cycle, sender: coordinator, receiver: hub, incoming: false, ^^^^ spec/controllers/admin/order_cycles_controller_spec.rb:374:101: C: Layout/LineLength: Line is too long. [102/100] expect(json_response['errors']).to eq 'Hm, something went wrong. No order cycle data found.' ^^ spec/controllers/admin/order_cycles_controller_spec.rb:460:101: C: Layout/LineLength: Line is too long. [176/100] expect(flash[:error]).to eq 'That order cycle has been selected by a customer and cannot be deleted. To prevent customers from accessing it, please close it instead.' ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/controllers/admin/order_cycles_controller_spec.rb:470:101: C: Layout/LineLength: Line is too long. [147/100] expect(flash[:error]).to eq 'That order cycle is linked to a schedule and cannot be deleted. Please unlink or delete the schedule first.' ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/controllers/api/v0/order_cycles_controller_spec.rb:16:101: C: [Corrected] Layout/LineLength: Line is too long. [106/100] let!(:product1) { create(:product, name: "Kangaroo", primary_taxon: taxon1, properties: [property1]) } ^^^^^^ spec/controllers/api/v0/order_cycles_controller_spec.rb:17:1: C: [Corrected] Layout/IndentationWidth: Use 2 (not 1) spaces for indentation. create(:product, name: "Kangaroo", primary_taxon: taxon1, properties: [property1]) ^ spec/controllers/api/v0/order_cycles_controller_spec.rb:17:3: C: [Corrected] Layout/IndentationWidth: Use 2 (not -2) spaces for indentation. create(:product, name: "Kangaroo", primary_taxon: taxon1, properties: [property1]) ^^ spec/controllers/api/v0/order_cycles_controller_spec.rb:17:85: C: [Corrected] Layout/BlockEndNewline: Expression at 17, 85 should be on its own line. create(:product, name: "Kangaroo", primary_taxon: taxon1, properties: [property1]) } ^ spec/controllers/api/v0/order_cycles_controller_spec.rb:17:101: C: [Corrected] Layout/LineLength: Line is too long. [106/100] let!(:product2) { create(:product, name: "Parsnips", primary_taxon: taxon2, properties: [property2]) } ^^^^^^ spec/controllers/api/v0/order_cycles_controller_spec.rb:18:1: C: [Corrected] Layout/BlockAlignment: } at 18, 0 is not aligned with let!(:product1) { at 16, 4. } ^ spec/controllers/api/v0/order_cycles_controller_spec.rb:19:85: C: [Corrected] Layout/BlockEndNewline: Expression at 19, 85 should be on its own line. create(:product, name: "Parsnips", primary_taxon: taxon2, properties: [property2]) } ^ spec/controllers/api/v0/order_cycles_controller_spec.rb:20:1: C: [Corrected] Layout/IndentationWidth: Use 2 (not 1) spaces for indentation. create(:product, name: "Parsnips", primary_taxon: taxon2, properties: [property2]) ^ spec/controllers/api/v0/order_cycles_controller_spec.rb:20:3: C: [Corrected] Layout/IndentationWidth: Use 2 (not -2) spaces for indentation. create(:product, name: "Parsnips", primary_taxon: taxon2, properties: [property2]) ^^ spec/controllers/api/v0/order_cycles_controller_spec.rb:21:1: C: [Corrected] Layout/BlockAlignment: } at 21, 0 is not aligned with let!(:product2) { at 19, 4. } ^ spec/controllers/spree/admin/orders_controller_spec.rb:232:101: C: [Corrected] Layout/LineLength: Line is too long. [117/100] let!(:order_cycle){ create(:simple_order_cycle, distributors: [distributor], variants: [line_item.variant]) } ^^^^^^^^^^^^^^^^^ spec/controllers/spree/admin/orders_controller_spec.rb:233:1: C: [Corrected] Layout/IndentationWidth: Use 2 (not 1) spaces for indentation. create(:simple_order_cycle, distributors: [distributor], variants: [line_item.variant]) ^ spec/controllers/spree/admin/orders_controller_spec.rb:233:3: C: [Corrected] Layout/IndentationWidth: Use 2 (not -6) spaces for indentation. create(:simple_order_cycle, distributors: [distributor], variants: [line_item.variant]) ^^^^^^ spec/controllers/spree/admin/orders_controller_spec.rb:233:90: C: [Corrected] Layout/BlockEndNewline: Expression at 233, 90 should be on its own line. create(:simple_order_cycle, distributors: [distributor], variants: [line_item.variant]) } ^ spec/controllers/spree/admin/orders_controller_spec.rb:234:1: C: [Corrected] Layout/BlockAlignment: } at 234, 0 is not aligned with let!(:order_cycle){ at 232, 8. } ^ spec/controllers/spree/admin/orders_controller_spec.rb:252:101: C: Layout/LineLength: Line is too long. [109/100] allow_any_instance_of(Spree::Order).to receive(:ensure_available_shipping_rates).and_return(true) ^^^^^^^^^ spec/lib/reports/customers_report_spec.rb:93:88: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. create(:order_with_totals_and_distribution, :completed, distributor: d, ^ spec/lib/reports/customers_report_spec.rb:93:101: C: [Corrected] Layout/LineLength: Line is too long. [125/100] create(:order_with_totals_and_distribution, :completed, distributor: d, bill_address: a, shipping_method: sm) ^^^^^^^^^^^^^^^^^^^^^^^^^ spec/lib/reports/customers_report_spec.rb:94:1: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line. bill_address: a, shipping_method: sm) ^^^^^^^^^^^^^^^ spec/lib/reports/customers_report_spec.rb:94:101: C: Layout/LineLength: Line is too long. [109/100] bill_address: a, shipping_method: sm) ^^^^^^^^^ spec/lib/reports/customers_report_spec.rb:96:101: C: [Corrected] Layout/LineLength: Line is too long. [125/100] create(:order_with_totals_and_distribution, :completed, distributor: d, bill_address: a, shipping_method: sm) ^^^^^^^^^^^^^^^^^^^^^^^^^ spec/lib/reports/customers_report_spec.rb:97:88: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. create(:order_with_totals_and_distribution, :completed, distributor: d, ^ spec/lib/reports/customers_report_spec.rb:98:1: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line. bill_address: a, shipping_method: sm) ^^^^^^^^^^^^^^^ spec/lib/reports/customers_report_spec.rb:98:101: C: Layout/LineLength: Line is too long. [109/100] bill_address: a, shipping_method: sm) ^^^^^^^^^ spec/lib/reports/customers_report_spec.rb:113:101: C: Layout/LineLength: Line is too long. [118/100] [d.address.address1, d.address.address2, d.address.city].join(" "), ^^^^^^^^^^^^^^^^^^ spec/lib/reports/customers_report_spec.rb:120:101: C: [Corrected] Layout/LineLength: Line is too long. [129/100] create(:order_with_totals_and_distribution, :completed, distributor: d2, bill_address: a, shipping_method: sm2) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/lib/reports/customers_report_spec.rb:122:91: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. create(:order_with_totals_and_distribution, :completed, distributor: d2, ^ spec/lib/reports/customers_report_spec.rb:123:1: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line. bill_address: a, shipping_method: sm2) ^^^^^^^^^^^^^^^ spec/lib/reports/customers_report_spec.rb:123:101: C: Layout/LineLength: Line is too long. [112/100] bill_address: a, shipping_method: sm2) ^^^^^^^^^^^^ spec/lib/reports/customers_report_spec.rb:133:101: C: Layout/LineLength: Line is too long. [120/100] [d.address.address1, d.address.address2, d.address.city].join(" "), ^^^^^^^^^^^^^^^^^^^^ spec/lib/reports/customers_report_spec.rb:139:101: C: Layout/LineLength: Line is too long. [123/100] [d2.address.address1, d2.address.address2, d2.address.city].join(" "), ^^^^^^^^^^^^^^^^^^^^^^^ spec/lib/reports/customers_report_spec.rb:145:101: C: [Corrected] Layout/LineLength: Line is too long. [128/100] create(:order_with_totals_and_distribution, :completed, distributor: d, bill_address: a, shipping_method: sm2) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/lib/reports/customers_report_spec.rb:148:90: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. create(:order_with_totals_and_distribution, :completed, distributor: d, ^ spec/lib/reports/customers_report_spec.rb:149:1: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line. bill_address: a, shipping_method: sm2) ^^^^^^^^^^^^^^^ spec/lib/reports/customers_report_spec.rb:149:101: C: Layout/LineLength: Line is too long. [112/100] bill_address: a, shipping_method: sm2) ^^^^^^^^^^^^ spec/migrations/migrate_customer_names_spec.rb:16:101: C: Layout/LineLength: Line is too long. [122/100] value_type: "boolean", key: "/enterprise/show_customer_names_to_suppliers/#{enterprise1.id}") ^^^^^^^^^^^^^^^^^^^^^^ spec/migrations/migrate_customer_names_spec.rb:18:101: C: Layout/LineLength: Line is too long. [122/100] value_type: "boolean", key: "/enterprise/show_customer_names_to_suppliers/#{enterprise2.id}") ^^^^^^^^^^^^^^^^^^^^^^ spec/migrations/migrate_customer_names_spec.rb:20:101: C: Layout/LineLength: Line is too long. [122/100] value_type: "boolean", key: "/enterprise/show_customer_names_to_suppliers/#{enterprise4.id}") ^^^^^^^^^^^^^^^^^^^^^^ spec/models/enterprise_spec.rb:521:101: C: [Corrected] Layout/LineLength: Line is too long. [111/100] expect(Enterprise.supplying_variant_in([p1.variants.first, p2.variants.first])).to match_array [s1, s2] ^^^^^^^^^^^ spec/models/enterprise_spec.rb:522:1: C: [Corrected] Layout/ArrayAlignment: Align the elements of an array literal if they span more than one line. p2.variants.first])).to match_array [s1, s2] ^^^^^^^^^^^^^^^^^ spec/models/order_cycle_spec.rb:207:101: C: Layout/LineLength: Line is too long. [118/100] expect(oc.variants).to match_array [p0.variants.first, p1.variants.first, p2.variants.first, p2_v, p1_v_visible, ^^^^^^^^^^^^^^^^^^ spec/models/order_cycle_spec.rb:220:101: C: Layout/LineLength: Line is too long. [111/100] expect(oc.distributed_variants).to match_array [p1.variants.first, p2.variants.first, p2_v, p1_v_visible, ^^^^^^^^^^^ spec/models/product_importer_spec.rb:782:101: C: Layout/LineLength: Line is too long. [101/100] csv << [" Oats ", "\nPorridge Oats\n", "\r#{enterprise2.name}\r", "\t#{enterprise.name}\t", ^ spec/models/spree/ability_spec.rb:340:69: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. [:admin, :index, :read, :edit, :update, :search, :destroy, ^ spec/models/spree/ability_spec.rb:340:101: C: [Corrected] Layout/LineLength: Line is too long. [101/100] [:admin, :index, :read, :edit, :update, :search, :destroy, :delete], for: p1.variants.first ^ spec/models/spree/ability_spec.rb:341:1: C: [Corrected] Layout/ArrayAlignment: Align the elements of an array literal if they span more than one line. :delete], for: p1.variants.first ^^^^^^^ spec/models/spree/ability_spec.rb:350:101: C: [Corrected] Layout/LineLength: Line is too long. [108/100] [:admin, :index, :read, :edit, :update, :search, :destroy, :delete], for: p_related.variants.first ^^^^^^^^ spec/models/spree/ability_spec.rb:351:69: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. [:admin, :index, :read, :edit, :update, :search, :destroy, ^ spec/models/spree/ability_spec.rb:352:1: C: [Corrected] Layout/ArrayAlignment: Align the elements of an array literal if they span more than one line. :delete], for: p_related.variants.first ^^^^^^^ spec/models/spree/ability_spec.rb:379:101: C: [Corrected] Layout/LineLength: Line is too long. [101/100] [:admin, :index, :read, :create, :edit, :search, :update, :destroy], for: p2.variants.first ^ spec/models/spree/ability_spec.rb:381:68: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. [:admin, :index, :read, :create, :edit, :search, :update, ^ spec/models/spree/ability_spec.rb:382:1: C: [Corrected] Layout/ArrayAlignment: Align the elements of an array literal if they span more than one line. :destroy], for: p2.variants.first ^^^^^^^^ spec/models/spree/adjustment_spec.rb:339:101: C: Layout/LineLength: Line is too long. [106/100] create(:tax_rate, included_in_price: true, calculator: ::Calculator::DefaultTax.new, zone: zone, ^^^^^^ spec/models/spree/adjustment_spec.rb:367:101: C: Layout/LineLength: Line is too long. [101/100] calculator: ::Calculator::FlatRate.new(preferred_amount: 50.0)) ^ spec/models/spree/adjustment_spec.rb:428:101: C: Layout/LineLength: Line is too long. [105/100] context "when enterprise fees inherit their tax_category from the product they are applied to" do ^^^^^ spec/models/spree/adjustment_spec.rb:443:101: C: Layout/LineLength: Line is too long. [101/100] calculator: ::Calculator::FlatRate.new(preferred_amount: 50.0)) ^ spec/models/spree/line_item_spec.rb:208:101: C: Layout/LineLength: Line is too long. [107/100] expect(LineItem.from_order_cycle(oc_order.order_cycle).first.id).to eq oc_order.line_items.first.id ^^^^^^^ spec/models/spree/line_item_spec.rb:342:101: C: Layout/LineLength: Line is too long. [102/100] Spree::Variant.find(variant.id).on_hand ^^ spec/models/spree/product_spec.rb:409:74: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. create(:simple_order_cycle, suppliers: [s], distributors: [d1], ^ spec/models/spree/product_spec.rb:409:101: C: [Corrected] Layout/LineLength: Line is too long. [104/100] create(:simple_order_cycle, suppliers: [s], distributors: [d1], variants: [p1.variants.first]) ^^^^ spec/models/spree/product_spec.rb:410:1: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line. variants: [p1.variants.first]) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/models/spree/product_spec.rb:410:101: C: [Corrected] Layout/LineLength: Line is too long. [104/100] create(:simple_order_cycle, suppliers: [s], distributors: [d2], variants: [p2.variants.first]) ^^^^ spec/models/spree/product_spec.rb:411:74: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. create(:simple_order_cycle, suppliers: [s], distributors: [d2], ^ spec/models/spree/product_spec.rb:412:1: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line. variants: [p2.variants.first]) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/models/spree/product_spec.rb:486:101: C: [Corrected] Layout/LineLength: Line is too long. [104/100] create(:simple_order_cycle, suppliers: [s], distributors: [d1], variants: [p1.variants.first]) ^^^^ spec/models/spree/product_spec.rb:487:101: C: [Corrected] Layout/LineLength: Line is too long. [104/100] create(:simple_order_cycle, suppliers: [s], distributors: [d2], variants: [p2.variants.first]) ^^^^ spec/models/spree/product_spec.rb:488:74: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. create(:simple_order_cycle, suppliers: [s], distributors: [d1], ^ spec/models/spree/product_spec.rb:489:1: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line. variants: [p1.variants.first]) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/models/spree/product_spec.rb:490:74: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. create(:simple_order_cycle, suppliers: [s], distributors: [d2], ^ spec/models/spree/product_spec.rb:491:1: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line. variants: [p2.variants.first]) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/models/spree/product_spec.rb:495:101: C: [Corrected] Layout/LineLength: Line is too long. [102/100] create(:simple_order_cycle, suppliers: [s], distributors: [d], variants: [p.variants.first]) ^^ spec/models/spree/product_spec.rb:499:73: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. create(:simple_order_cycle, suppliers: [s], distributors: [d], ^ spec/models/spree/product_spec.rb:500:1: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line. variants: [p.variants.first]) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/models/spree/variant_spec.rb:356:101: C: Layout/LineLength: Line is too long. [108/100] it "lists any variants that are not listed as visible=false only for the relevant enterprise" do ^^^^^^^^ spec/models/spree/variant_spec.rb:479:101: C: Layout/LineLength: Line is too long. [108/100] expect_any_instance_of(OpenFoodNetwork::EnterpriseFeeCalculator).to receive(:fees_for).with(variant) { ^^^^^^^^ spec/models/spree/variant_spec.rb:494:101: C: Layout/LineLength: Line is too long. [116/100] expect_any_instance_of(OpenFoodNetwork::EnterpriseFeeCalculator).to receive(:fees_by_type_for).with(variant) { ^^^^^^^^^^^^^^^^ spec/models/spree/variant_spec.rb:704:101: C: Layout/LineLength: Line is too long. [115/100] expect_any_instance_of(VariantUnits::OptionValueNamer).to receive(:name).exactly(1).times.and_call_original ^^^^^^^^^^^^^^^ spec/requests/api/orders_spec.rb:167:88: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. create(:order_with_line_items, line_items_count: 1, bill_address_id: nil, ^ spec/requests/api/orders_spec.rb:167:101: C: [Corrected] Layout/LineLength: Line is too long. [109/100] create(:order_with_line_items, line_items_count: 1, bill_address_id: nil, ship_address_id: nil) ^^^^^^^^^ spec/requests/api/orders_spec.rb:168:1: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line. ship_address_id: nil) ^^^^^^^^^^^^^^^^^^^^ spec/services/products_renderer_spec.rb:91:101: C: Layout/LineLength: Line is too long. [101/100] { q: { with_properties: [property_organic.id] } }) ^ spec/services/products_renderer_spec.rb:100:101: C: Layout/LineLength: Line is too long. [101/100] { q: { with_properties: [property_organic.id] } }) ^ spec/services/products_renderer_spec.rb:118:101: C: Layout/LineLength: Line is too long. [101/100] { q: { with_properties: [property_organic.id] } }) ^ spec/support/request/web_helper.rb:96:84: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. tomselect_wrapper.find(:css, '.ts-dropdown.multi .ts-dropdown-content .option', ^ spec/support/request/web_helper.rb:96:101: C: [Corrected] Layout/LineLength: Line is too long. [102/100] tomselect_wrapper.find(:css, '.ts-dropdown.multi .ts-dropdown-content .option', text: value).click ^^ spec/support/request/web_helper.rb:97:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line. text: value).click ^^^^^^^^^^^ spec/system/admin/adjustments_spec.rb:29:101: C: [Corrected] Layout/LineLength: Line is too long. [197/100] let!(:tax_rate2) { create(:tax_rate, name: "TVA 20%", amount: 0.2, zone: default_tax_zone, included_in_price: true, tax_category: tax_category_included, calculator: Calculator::DefaultTax.new ) } ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/system/admin/adjustments_spec.rb:30:1: C: [Corrected] Layout/IndentationWidth: Use 2 (not 1) spaces for indentation. create(:tax_rate, name: "TVA 20%", amount: 0.2, zone: default_tax_zone, included_in_price: true, ^ spec/system/admin/adjustments_spec.rb:30:3: C: [Corrected] Layout/IndentationWidth: Use 2 (not 0) spaces for indentation. create(:tax_rate, name: "TVA 20%", amount: 0.2, zone: default_tax_zone, included_in_price: true, spec/system/admin/adjustments_spec.rb:30:98: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. create(:tax_rate, name: "TVA 20%", amount: 0.2, zone: default_tax_zone, included_in_price: true, ^ spec/system/admin/adjustments_spec.rb:30:101: C: [Corrected] Layout/LineLength: Line is too long. [177/100] create(:tax_rate, name: "TVA 20%", amount: 0.2, zone: default_tax_zone, included_in_price: true, tax_category: tax_category_included, calculator: Calculator::DefaultTax.new ) } ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/system/admin/adjustments_spec.rb:30:177: C: [Corrected] Layout/BlockEndNewline: Expression at 30, 177 should be on its own line. create(:tax_rate, name: "TVA 20%", amount: 0.2, zone: default_tax_zone, included_in_price: true, tax_category: tax_category_included, calculator: Calculator::DefaultTax.new ) } ^ spec/system/admin/adjustments_spec.rb:31:1: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line. tax_category: tax_category_included, calculator: Calculator::DefaultTax.new ) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/system/admin/adjustments_spec.rb:32:1: C: [Corrected] Layout/BlockAlignment: } at 32, 0 is not aligned with let!(:tax_rate2) { at 29, 2. } ^ spec/system/admin/adjustments_spec.rb:41:101: C: Layout/LineLength: Line is too long. [134/100] shared_examples "when the enable_localized_number preference" do |adjustment_label, adjustment_amount, tax_category, tax, tax_total| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/system/admin/adjustments_spec.rb:67:101: C: [Corrected] Layout/LineLength: Line is too long. [117/100] it_behaves_like "when the enable_localized_number preference", "Discount", "-2", "TVA 20%", "$0.33", "$-1.67" ^^^^^^^^^^^^^^^^^ spec/system/admin/adjustments_spec.rb:68:100: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. it_behaves_like "when the enable_localized_number preference", "Discount", "-2", "TVA 20%", ^ spec/system/admin/adjustments_spec.rb:69:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line. "$0.33", "$-1.67" ^^^^^^^ spec/system/admin/adjustments_spec.rb:71:101: C: [Corrected] Layout/LineLength: Line is too long. [120/100] it_behaves_like "when the enable_localized_number preference", "Late fee", "100", "TVA 20%", "$-16.67", "$83.33" ^^^^^^^^^^^^^^^^^^^^ spec/system/admin/adjustments_spec.rb:73:90: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. it_behaves_like "when the enable_localized_number preference", "Late fee", "100", ^ spec/system/admin/adjustments_spec.rb:74:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line. "TVA 20%", "$-16.67", "$83.33" ^^^^^^^^^ spec/system/admin/adjustments_spec.rb:77:101: C: [Corrected] Layout/LineLength: Line is too long. [113/100] it_behaves_like "when the enable_localized_number preference", "Discount", "-2", "GST", "$10.00", "$8.00" ^^^^^^^^^^^^^ spec/system/admin/adjustments_spec.rb:80:96: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. it_behaves_like "when the enable_localized_number preference", "Discount", "-2", "GST", ^ spec/system/admin/adjustments_spec.rb:81:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line. "$10.00", "$8.00" ^^^^^^^^ spec/system/admin/adjustments_spec.rb:81:101: C: [Corrected] Layout/LineLength: Line is too long. [113/100] it_behaves_like "when the enable_localized_number preference", "Late fee", "110", "GST", "$10.00", "$120" ^^^^^^^^^^^^^ spec/system/admin/adjustments_spec.rb:85:97: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. it_behaves_like "when the enable_localized_number preference", "Late fee", "110", "GST", ^ spec/system/admin/adjustments_spec.rb:86:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line. "$10.00", "$120" ^^^^^^^^ spec/system/admin/adjustments_spec.rb:93:101: C: [Corrected] Layout/LineLength: Line is too long. [117/100] it_behaves_like "when the enable_localized_number preference", "Discount", "-2", "TVA 20%", "$0.33", "$-1.67" ^^^^^^^^^^^^^^^^^ spec/system/admin/adjustments_spec.rb:97:101: C: [Corrected] Layout/LineLength: Line is too long. [120/100] it_behaves_like "when the enable_localized_number preference", "Late fee", "100", "TVA 20%", "$-16.67", "$83.33" ^^^^^^^^^^^^^^^^^^^^ spec/system/admin/adjustments_spec.rb:98:100: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. it_behaves_like "when the enable_localized_number preference", "Discount", "-2", "TVA 20%", ^ spec/system/admin/adjustments_spec.rb:99:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line. "$0.33", "$-1.67" ^^^^^^^ spec/system/admin/adjustments_spec.rb:103:90: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. it_behaves_like "when the enable_localized_number preference", "Late fee", "100", ^ spec/system/admin/adjustments_spec.rb:103:101: C: [Corrected] Layout/LineLength: Line is too long. [113/100] it_behaves_like "when the enable_localized_number preference", "Discount", "-2", "GST", "$10.00", "$8.00" ^^^^^^^^^^^^^ spec/system/admin/adjustments_spec.rb:104:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line. "TVA 20%", "$-16.67", "$83.33" ^^^^^^^^^ spec/system/admin/adjustments_spec.rb:107:101: C: [Corrected] Layout/LineLength: Line is too long. [113/100] it_behaves_like "when the enable_localized_number preference", "Late fee", "110", "GST", "$10.00", "$120" ^^^^^^^^^^^^^ spec/system/admin/adjustments_spec.rb:110:96: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. it_behaves_like "when the enable_localized_number preference", "Discount", "-2", "GST", ^ spec/system/admin/adjustments_spec.rb:111:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line. "$10.00", "$8.00" ^^^^^^^^ spec/system/admin/adjustments_spec.rb:115:97: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. it_behaves_like "when the enable_localized_number preference", "Late fee", "110", "GST", ^ spec/system/admin/adjustments_spec.rb:116:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line. "$10.00", "$120" ^^^^^^^^ spec/system/admin/bulk_order_management_spec.rb:268:101: C: Layout/LineLength: Line is too long. [105/100] text: "#{o1.bill_address.last_name}, #{o1.bill_address.first_name}" ^^^^^ spec/system/admin/bulk_order_management_spec.rb:1036:101: C: Layout/LineLength: Line is too long. [147/100] expect(page).to have_content "This operation will result in one or more empty orders, which will be cancelled. Do you wish to proceed?" ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/system/admin/bulk_order_management_spec.rb:1060:101: C: Layout/LineLength: Line is too long. [138/100] it "the user can confirm + wants to send email confirmation : line item is then deleted, order is canceled and email is sent" do ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/system/admin/bulk_order_management_spec.rb:1072:101: C: Layout/LineLength: Line is too long. [134/100] it "the user can confirm + uncheck the restock option: line item is then deleted and order is canceled without retocking" do ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/system/admin/customers_spec.rb:40:101: C: Layout/LineLength: Line is too long. [126/100] managed_distributor2.name], without_options: [unmanaged_distributor.name] ^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/system/admin/order_cycles/simple_spec.rb:346:101: C: Layout/LineLength: Line is too long. [101/100] with_options: [schedule_of_other_managed_distributor.name] ^ spec/system/admin/order_cycles/simple_spec.rb:623:101: C: Layout/LineLength: Line is too long. [121/100] value: Time.zone.local(2040, 10, 17, 0o6, 0o0, 0o0).strftime("%F %T %z"), visible: false ^^^^^^^^^^^^^^^^^^^^^ spec/system/admin/order_cycles/simple_spec.rb:625:101: C: Layout/LineLength: Line is too long. [120/100] value: Time.zone.local(2040, 10, 24, 17, 0o0, 0o0).strftime("%F %T %z"), visible: false ^^^^^^^^^^^^^^^^^^^^ spec/system/admin/order_cycles/simple_spec.rb:733:101: C: Layout/LineLength: Line is too long. [121/100] value: Time.zone.local(2040, 10, 17, 0o6, 0o0, 0o0).strftime("%F %T %z"), visible: false ^^^^^^^^^^^^^^^^^^^^^ spec/system/admin/order_cycles/simple_spec.rb:735:101: C: Layout/LineLength: Line is too long. [120/100] value: Time.zone.local(2040, 10, 24, 17, 0o0, 0o0).strftime("%F %T %z"), visible: false ^^^^^^^^^^^^^^^^^^^^ spec/system/admin/order_spec.rb:598:101: C: [Corrected] Layout/LineLength: Line is too long. [101/100] expect(page).to have_link "Resend Confirmation", href: spree.resend_admin_order_path(order) ^ spec/system/admin/order_spec.rb:599:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line. href: spree.resend_admin_order_path(order) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/system/admin/order_spec.rb:616:101: C: [Corrected] Layout/LineLength: Line is too long. [105/100] expect(page).to have_link "Cancel Order", href: spree.fire_admin_order_path(order, e: 'cancel') ^^^^^ spec/system/admin/order_spec.rb:618:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line. href: spree.fire_admin_order_path(order, e: 'cancel') ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/system/admin/orders_spec.rb:259:101: C: Layout/LineLength: Line is too long. [109/100] distributor: distributor2, bill_address_id: nil, ship_address_id: nil) ^^^^^^^^^ spec/system/admin/product_import_spec.rb:573:101: C: Layout/LineLength: Line is too long. [106/100] expect(page).to have_content "line 4: Cabbage - On_hand incorrect value - On_demand incorrect value" ^^^^^^ spec/system/admin/product_import_spec.rb:574:101: C: Layout/LineLength: Line is too long. [108/100] expect(page).to have_content "line 5: Aubergine - On_hand incorrect value - On_demand incorrect value" ^^^^^^^^ spec/system/admin/product_import_spec.rb:583:101: C: Layout/LineLength: Line is too long. [102/100] csv << ["name", "producer", "category", "on_hand", "price", "on_demand", "units", "unit_type", ^^ spec/system/admin/product_import_spec.rb:585:101: C: Layout/LineLength: Line is too long. [106/100] csv << ["Beans", "User Enterprise", "Vegetables", "invalid", "3.50", "1", "0.5", "g", "Small Bag", ^^^^^^ spec/system/admin/product_import_spec.rb:587:101: C: Layout/LineLength: Line is too long. [103/100] csv << ["Potatoes", "User Enterprise", "Vegetables", "6", "6", "invalid", "5", "kg", "Big Bag", ^^^ spec/system/admin/product_import_spec.rb:589:101: C: Layout/LineLength: Line is too long. [106/100] csv << ["Cabbage", "User Enterprise", "Vegetables", "invalid", "1.5", "invalid", "1", "kg", "Bag", ^^^^^^ spec/system/admin/product_import_spec.rb:591:101: C: Layout/LineLength: Line is too long. [102/100] csv << ["Aubergine", "User Enterprise", "Vegetables", nil, "1.5", "invalid", "1", "kg", "Bag", ^^ spec/system/admin/product_import_spec.rb:607:101: C: Layout/LineLength: Line is too long. [114/100] expect(page).to have_content "line 4: Cabbage ( Bag ) - On_hand incorrect value - On_demand incorrect value" ^^^^^^^^^^^^^^ spec/system/admin/product_import_spec.rb:608:101: C: Layout/LineLength: Line is too long. [116/100] expect(page).to have_content "line 5: Aubergine ( Bag ) - On_hand incorrect value - On_demand incorrect value" ^^^^^^^^^^^^^^^^ spec/system/admin/product_import_spec.rb:617:101: C: Layout/LineLength: Line is too long. [102/100] csv << ["name", "producer", "category", "on_hand", "price", "on_demand", "units", "unit_type", ^^ spec/system/admin/product_import_spec.rb:619:101: C: Layout/LineLength: Line is too long. [101/100] csv << ["Beans", "User Enterprise", "Vegetables", "-1", "3.50", "1", "500", "g", "Small Bag", ^ spec/system/admin/product_import_spec.rb:641:101: C: Layout/LineLength: Line is too long. [114/100] expect(page).to have_content "line 4: Cabbage ( Bag ) - On_hand incorrect value - On_demand incorrect value" ^^^^^^^^^^^^^^ spec/system/admin/product_import_spec.rb:642:101: C: Layout/LineLength: Line is too long. [116/100] expect(page).to have_content "line 5: Aubergine ( Bag ) - On_hand incorrect value - On_demand incorrect value" ^^^^^^^^^^^^^^^^ spec/system/consumer/shopping/cart_spec.rb:147:101: C: Layout/LineLength: Line is too long. [101/100] preferred_unit_from_list: "kg"), ^ spec/system/consumer/shopping/products_spec.rb:98:101: C: Layout/LineLength: Line is too long. [113/100] "<script>alert('Dangerous!');</script>", truncate: false) ^^^^^^^^^^^^^ 1478 files inspected, 173 offenses detected, 106 offenses corrected

mkllnk

Nice work. I like it when an automated tool highlights a mistake in the code.

mkllnk · 2023-07-24T03:17:50Z

spec/system/admin/order_cycles/complex_updating_specific_time_spec.rb

    expect(page).to have_selector
-      "#order_cycle_incoming_exchange_1_variants_#{initial_variants.last.id}"
+    "#order_cycle_incoming_exchange_1_variants_#{initial_variants.last.id}"


This is interesting. Does this mean that the string is not seen as method argument? Oh, I can't test it because the whole spec is disabled. This is dead and broken code. Apparently this spec was commented out as flaky three years ago:

042b4fa

@filipefurtad0 Can you asses if we should fix the spec or delete it?

Nice, thanks for digging that out. I would keep it and create an issue to keep track of it - I did so here.

I've tried to fix it, but it's not a quick win, it's difficult to get a consistent behavior in the OC pages (the add Distributor button...)... Anyway, out of scope here.

mkllnk · 2023-07-24T03:21:32Z

spec/system/admin/order_cycles/simple_spec.rb

      expect(page).to have_checked_field
-        "order_cycle_selected_distributor_payment_method_ids_#{distributor_payment_method_id}"
+      "order_cycle_selected_distributor_payment_method_ids_#{distributor_payment_method_id}"


I confirmed for this spec that the string was ignored and not passed on as an argument. Adding parenthesis fixes the code. I will add a commit.

mkllnk · 2023-07-24T03:26:20Z

spec/system/admin/adjustments_spec.rb

+        it_behaves_like "when the enable_localized_number preference", "Discount", "-2", "TVA 20%",
+                        "$0.33", "$-1.67"


It would probably be nicer to have all the values in one line.

rioug

Nice one !

rioug · 2023-07-24T03:49:12Z

Waiting on Filipe's feedback before merging

filipefurtad0 · 2023-07-24T12:05:43Z

Waiting on Filipe's feedback before merging

Good to merge on my end 👍

macanudo527 force-pushed the fix_rubocop_layout_1 branch from bf059c1 to 94f04f4 Compare July 21, 2023 14:44

macanudo527 added 5 commits July 24, 2023 09:14

macanudo527 force-pushed the fix_rubocop_layout_1 branch from 94f04f4 to bede52b Compare July 24, 2023 00:14

Fix specs with missign parenthesis

a677444

mkllnk approved these changes Jul 24, 2023

View reviewed changes

Ease reading with related spec values on one line

f36ca77

rioug approved these changes Jul 24, 2023

View reviewed changes

filipefurtad0 mentioned this pull request Jul 24, 2023

[Flaky] ./spec/system/admin/order_cycles/complex_updating_specific_time_spec.rb (commented out) #11266

Open

filipefurtad0 merged commit 1e2fb07 into openfoodfoundation:master Jul 24, 2023
50 checks passed

macanudo527 deleted the fix_rubocop_layout_1 branch July 24, 2023 13:32

macanudo527 mentioned this pull request Jul 27, 2023

Fix rubocop layout 3 #11283

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Rubocop Layout violations - 2 #11261

Fix Rubocop Layout violations - 2 #11261

macanudo527 commented Jul 21, 2023

mkllnk left a comment

mkllnk Jul 24, 2023

filipefurtad0 Jul 24, 2023

mkllnk Jul 24, 2023

mkllnk Jul 24, 2023

rioug left a comment

rioug commented Jul 24, 2023

filipefurtad0 commented Jul 24, 2023

		it_behaves_like "when the enable_localized_number preference", "Discount", "-2", "TVA 20%",
		"$0.33", "$-1.67"

Fix Rubocop Layout violations - 2 #11261

Fix Rubocop Layout violations - 2 #11261

Conversation

macanudo527 commented Jul 21, 2023

What? Why?

What should we test?

Release notes

Dependencies

Documentation updates

mkllnk left a comment

Choose a reason for hiding this comment

mkllnk Jul 24, 2023

Choose a reason for hiding this comment

filipefurtad0 Jul 24, 2023

Choose a reason for hiding this comment

mkllnk Jul 24, 2023

Choose a reason for hiding this comment

mkllnk Jul 24, 2023

Choose a reason for hiding this comment

rioug left a comment

Choose a reason for hiding this comment

rioug commented Jul 24, 2023

filipefurtad0 commented Jul 24, 2023