Add Ruby version to engines for Rubocop #11246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkllnk
force-pushed
the
engine-ruby-version
branch
from
714794d
to
e028666
Compare
|
Lots of specs are actually failing. Moving into |
mkllnk
force-pushed
the
engine-ruby-version
branch
from
e028666
to
c5ba7c8
Compare
Oh, sorry for that. I fixed it now. |
> This ensures that RuboCop is using the same Ruby version as the gem. https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Gemspec/RequiredRubyVersion
The Gemfile of the main app is used.
mkllnk
force-pushed
the
engine-ruby-version
branch
from
c5ba7c8
to
54f3966
Compare
dacook
approved these changes
Jul 21, 2023
|
Failing spec is flaky Ready to merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Gemspec/RequiredRubyVersion
What should we test?
No test.
Release notes
Changelog Category: Technical changes
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates