Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds assertion on the Out of Stock message #11236

Merged

Conversation

filipefurtad0
Copy link
Contributor

@filipefurtad0 filipefurtad0 commented Jul 19, 2023

What? Why?

A minor spec change regarding a Out of Stock warning displayed in the backoffice, while editing an order with line items which are out of stock. I feel it's useful to document this behavior, and assure we keep it - since it is a visible message to the user.

  • Asserts the message Out of Stock:

image

  • Asserts the message is not visible after removing the line item which is out of stock

What should we test?

  • Green build

Release notes

Changelog Category: Technical changes

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

Copy link
Contributor

@jibees jibees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@mkllnk mkllnk merged commit fd05f41 into openfoodfoundation:master Jul 20, 2023
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants