Drop unused Spree Promotion Tables #11162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rioug
force-pushed
the
DropSpreePromotionTables
branch
from
d2c0d6e
to
48c04e7
Compare
rioug
force-pushed
the
DropSpreePromotionTables
branch
from
48c04e7
to
b6d10df
Compare
|
@dacook or @Matt-Yorkley I can't merge this as I was the one who rebased the branch, could one of you take care of it ? |
|
I can merge once someone approves it, but I can't approve it because I'm the creator of the PR 😆 But I can bypass branch protections 🔨 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
We found some tables that aren't in use. We don't have models for these, and probably never used them.
I took a look at the au-prod database and found a small handful of records in a couple of tables, that don't seem to amount to anything (they weren't linked to any products). The timestamp was from 2013.
What should we test?
No application code has changed so I don't think we need to test anything.
Release notes
Changelog Category: Technical changes
The title of the pull request will be included in the release notes.