Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove split checkout from feature toggle #11159

Conversation

abdellani
Copy link
Member

What? Why?

This is after the comment

It looks like the split checkout was not removed from the feature toggle list on PR.

What should we test?

  • Check if the split checkout is removed from the Feature toggle list.

Release notes

Changelog Category: User facing changes | Technical changes

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

We don't need to enable split checkout, as this is default and unique mode.
@abdellani abdellani marked this pull request as ready for review July 5, 2023 15:16
@abdellani abdellani self-assigned this Jul 5, 2023
@abdellani
Copy link
Member Author

looks like the tests are failing because the CI env can't download the nodejs from https://nodejs.org

Copy link
Collaborator

@rioug rioug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one !

Copy link
Contributor

@jibees jibees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@filipefurtad0 filipefurtad0 self-assigned this Jul 13, 2023
@filipefurtad0 filipefurtad0 added the pr-staged-uk staging.openfoodnetwork.org.uk label Jul 13, 2023
@filipefurtad0
Copy link
Contributor

filipefurtad0 commented Jul 13, 2023

Hey @abdellani ,

This PR removes the split_checkout option from the Flipper menu:

image

Checkout works as before, on the server - so it seems not to have any impact on functionality, as we'd expect, by now.

Merging 👍

@filipefurtad0 filipefurtad0 removed the pr-staged-uk staging.openfoodnetwork.org.uk label Jul 13, 2023
@filipefurtad0 filipefurtad0 merged commit 9e0aa18 into openfoodfoundation:master Jul 13, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants