Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin, add trix editor to product description editor (both new and edit) #11140

Merged
merged 11 commits into from
Sep 4, 2023
Merged

Admin, add trix editor to product description editor (both new and edit) #11140

merged 11 commits into from
Sep 4, 2023

Commits on Sep 4, 2023

  1. Replace angular editor by trix editor

    @jibees
    jibees committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    e200ecc View commit details
    Browse the repository at this point in the history

  2. Update trixEditor rendering <a /> element: should be green

    @jibees
    jibees committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    b6e0470 View commit details
    Browse the repository at this point in the history

  3. We used to use <p> to seperate block between them. now use <div> 

    trix doesn't allow the use of `<p>` as block separator since it can not contain `<figure>`: use `<div>` and _emulate_ as `<p>` with margin bottom
    @jibees
    jibees committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    f9bc00e View commit details
    Browse the repository at this point in the history

  4. Sanitize content when display it on shop 

    Use the TrixSanitizer | TrixScrubber
    @jibees
    jibees committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    4c27e79 View commit details
    Browse the repository at this point in the history

  5. Add horizontal rule to trix editor

    @jibees
    jibees committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    a8a3531 View commit details
    Browse the repository at this point in the history

  6. Actually, this should not be sanitize before going through trix editor

    @jibees
    jibees committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    3225c52 View commit details
    Browse the repository at this point in the history

  7. Actually, used in the shopfront context, links are orange

    @jibees
    jibees committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    ca6d12e View commit details
    Browse the repository at this point in the history

  8. Special case for unordered list in trix editor: should be overwritten

    @jibees
    jibees committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    c402093 View commit details
    Browse the repository at this point in the history

  9. Create a mixin that include list of styles for trix editor + content 

    Will be used elsewhere (in shopfront in particular)
    @jibees
    jibees committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    34dab40 View commit details
    Browse the repository at this point in the history

  10. Include trix-styles mixin in where content from trix is displayed

    @jibees
    jibees committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    1d5d1c5 View commit details
    Browse the repository at this point in the history

  11. Add trix editor to new product form

    @jibees
    jibees committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    b6b64e9 View commit details
    Browse the repository at this point in the history