-
-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Admin, add trix editor to product description editor (both new and edit) #11140
Merged
drummer83
merged 11 commits into
openfoodfoundation:master
from
jibees:11129-add-trix-editor-to-product-description-editor
Sep 4, 2023
Merged
Admin, add trix editor to product description editor (both new and edit) #11140
drummer83
merged 11 commits into
openfoodfoundation:master
from
jibees:11129-add-trix-editor-to-product-description-editor
Sep 4, 2023
Commits on Sep 4, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e200ecc - Browse repository at this point
Copy the full SHA e200eccView commit details -
Configuration menu - View commit details
-
Copy full SHA for b6e0470 - Browse repository at this point
Copy the full SHA b6e0470View commit details -
We used to use
<p>
to seperate block between them. now use<div>
trix doesn't allow the use of `<p>` as block separator since it can not contain `<figure>`: use `<div>` and _emulate_ as `<p>` with margin bottom
Configuration menu - View commit details
-
Copy full SHA for f9bc00e - Browse repository at this point
Copy the full SHA f9bc00eView commit details -
Sanitize content when display it on shop
Use the TrixSanitizer | TrixScrubber
Configuration menu - View commit details
-
Copy full SHA for 4c27e79 - Browse repository at this point
Copy the full SHA 4c27e79View commit details -
Configuration menu - View commit details
-
Copy full SHA for a8a3531 - Browse repository at this point
Copy the full SHA a8a3531View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3225c52 - Browse repository at this point
Copy the full SHA 3225c52View commit details -
Configuration menu - View commit details
-
Copy full SHA for ca6d12e - Browse repository at this point
Copy the full SHA ca6d12eView commit details -
Configuration menu - View commit details
-
Copy full SHA for c402093 - Browse repository at this point
Copy the full SHA c402093View commit details -
Create a mixin that include list of styles for trix editor + content
Will be used elsewhere (in shopfront in particular)
Configuration menu - View commit details
-
Copy full SHA for 34dab40 - Browse repository at this point
Copy the full SHA 34dab40View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d5d1c5 - Browse repository at this point
Copy the full SHA 1d5d1c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for b6b64e9 - Browse repository at this point
Copy the full SHA b6b64e9View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.