Remove :permalink attribute from Product #11137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matt-Yorkley
force-pushed
the
remove-product-permalink
branch
7 times, most recently
from
4b090b3
to
0a1d7e0
Compare
|
We have a funded feature for direct product links in the pipe. Just bringing it up here to avoid thinking: "If only we had some sort of permalink already." in a few weeks/months. 😉🤷♂️ |
Then we should implement that on the Spree::Variant model and allow linking straight to variants. |
Matt-Yorkley
force-pushed
the
remove-product-permalink
branch
from
0a1d7e0
to
fefa928
Compare
mkllnk
approved these changes
Jul 3, 2023
rioug
reviewed
Jul 4, 2023
|
Hey @Matt-Yorkley , Yup, that checks: The Before the PR
After the PR
Quickly checked OCs, and checked out. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Removes
:permalinkattribute fromProductas discussed in #9069It turns out it was being utilised in a couple of weird places, but not for anything useful; mostly in building URLs that get used for navigating to the admin edit products page.
What should we test?
Not sure what to test here? The URLs on admin edit product page will use the product ID instead of a permalink based on the name, eg
/admin/products/18237/editinstead of/admin/products/bag-of-carrots/editRelease notes
Changelog Category: Technical changes
The title of the pull request will be included in the release notes.