-
-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove :permalink attribute from Product #11137
Remove :permalink attribute from Product #11137
Conversation
4b090b3
to
0a1d7e0
Compare
We have a funded feature for direct product links in the pipe. Just bringing it up here to avoid thinking: "If only we had some sort of permalink already." in a few weeks/months. 😉🤷♂️ |
Then we should implement that on the Spree::Variant model and allow linking straight to variants. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! 🙏
0a1d7e0
to
fefa928
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love seeing all that code going away 🧹
Hey @Matt-Yorkley , Yup, that checks: The Before the PR After the PR Quickly checked OCs, and checked out. |
What? Why?
Removes
:permalink
attribute fromProduct
as discussed in #9069It turns out it was being utilised in a couple of weird places, but not for anything useful; mostly in building URLs that get used for navigating to the admin edit products page.
What should we test?
Not sure what to test here? The URLs on admin edit product page will use the product ID instead of a permalink based on the name, eg
/admin/products/18237/edit
instead of/admin/products/bag-of-carrots/edit
Release notes
Changelog Category: Technical changes
The title of the pull request will be included in the release notes.