Checkout summary: avoid carriage return on price

[jibees]

What? Why?

• Closes [Checkout, Step 3, Order Details] Line break on currency (symbol and lettering) #11098

What should we test?

• In shopfront, check that when a price with currency is displayed, it should display without carriage return

Release notes

Changelog Category: User facing changes

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

[dacook]

Is this because someone accidentally entered a carriage return in the system config? Perhaps we should prevent that with validation (or simply strip it in the text input with pattern="".

This certainly solves it with the current data though 👍

---

Also I was curious to discover that we display prices with all the extra markup. And found that it's not on the shopfront or cart, only in the checkout summary.
Do you know why it's there and if it's necessary?

[jibees]

Is this because someone accidentally entered a carriage return in the system config?

Nop, it's because how the browser react to DOM.

Do you know why it's there and if it's necessary?

I noticed that also, but no... I'm not sure why it's used here and not in other places (as it should be I suppose)

[dacook]

Ohhh.. I see now, it's because there are spaces in the currency config, and the narrow columns caused it to wrap. Good fix 👍

[rioug]

Nice one !

[drummer83]

Hi @jibees,
we have a failing spec here. Moving to In Dev.

[filipefurtad0]

Hey @drummer83 @jibees

The failing spec looks like:
#11010

So maybe we're good to test?

Any clue why failing looks more persistent on this branch @jibees ?

[jibees]

Any clue why failing looks more persistent on this branch @jibees ?

Nop, locally, everything is fine

I've rebased the PR, and error is still present, and I think it's probably relevant. I should investigate, but I have no clue!

[jibees]

This is definitely flaky, and now it's green...

[drummer83]

Hi @jibees,
Thanks for this fix!

I can confirm that the /summary step of split checkout is fixed. I tested this for different screen sizes as well. 👍

We still see this issue for the order TOTAL on the /cart page and for payment and shipping fees (step 1 and 2 of split checkout) for some screen sizes. But this is out of scope here.

I think we are safe to merge this one. Thanks! 🙏

[jibees]

Yes, unfortunately, we don't use Spree::Money#to_html that much in the code, so my modification has only a little impact.