Restore line item ordering

[mkllnk]

What? Why?

The line item sorting by id has been replaced by sorting by completed_at time: ccb183d

While that's a good idea, the query param to order was only defined in the client Javascript and there was no default ordering. Line items also get their completed_at date from the order. So it's the same for all items of the same order and the ordering with that group of line items was random. Several specs became flaky.

Now we are sorting by id in addition. Items are first sorted by date and then by id if there's any ambiguity.

What should we test?

• Log in as admin of a hub with plenty of complete orders and visit /admin/orders/bulk_management
• Click "Completed at" header; take notice of the order range/ordering
• Move to another pagination index number.
• You might not have orders which should have been displayed on the first page

Release notes

Changelog Category: User facing changes

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

[dacook]

Good work, and thanks!

I see one failed spec, which relates to the bulk order screen.

rspec ./spec/system/admin/bulk_order_cancellation_spec.rb:28 # 

But I'll assume this is due to another issue that you refer to, and have re-run to see.

[drummer83]

Hi @mkllnk,
I tried to test this. However, I didn't see any line items on pages where they wouldn't belong even BEFORE this PR. Maybe bad luck...
So I thought by ID you meant the variant_id, but the results were not ordered by it AFTER the PR.
Then I thought, it's probably the Line Item ID of the order. So I added them to the screenshot below.

This is BEFORE your PR:

This is AFTER your PR:

We can see, that the line items of an order are now nicely sorted by line item ID. 👍

I think it would have been intuitive to use the variant_id as well - as I first thought - because that way similar orders would show the variants in the same order across different orders. The line item id instead depends on the order in which the customer put the items into the cart (I think), so similar orders will still show the variants in an order which seems random to the user. But that's not what this was about. I hope the specs are not flaky anymore now!

Thanks! Merging! 🚀

[mkllnk]

Very good idea, Konrad. I just focused on the technical part of making the specs less flaky. But I like your idea of ordering by variant id as well. It would be a tiny papercut. Maybe create a good first issue for this?