Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[admin_v3] Update all table styles #10948

Merged
merged 10 commits into from
Jun 13, 2023

Conversation

dacook
Copy link
Member

@dacook dacook commented Jun 7, 2023

What? Why?

This updates the general styles for all tables in the admin interface (behind feature toggle), according to the new design.

One example:
Screen Shot 2023-06-08 at 3 23 59 pm
Screen Shot 2023-06-08 at 3 24 12 pm

More context: while preparing for the new admin product table, I applied some of the new styles across all tables (because we want to do this anyway). I've extracted this from the closed PR.

What should we test?

The style changes are pretty low-risk changes, behind a feature toggle, and will continue to be refined before release, so I think we don't need to test for functionality at this point.

What's changed?

This includes some changes to background/foreground colours, which we might need to resolve before releasing the feature toggle.

  • odd/even table rows used to have different background colours, now they are mostly all white
  • pagination area used to be white, now it is grey (to accomodate white pagination buttons).
  • pagination buttons are now white with barely any border, but they should always appear inside the grey pagination area.

Other changes include:

  • base font colour has gone from the old blue to near-black (#191C1D). This changes the font colour inside tables, but also form labels and maybe other things.
  • Remove uppercasing of form elements and titles. They now appear mostly in sentence case, although I noticed an odd one out.

Release notes

Changelog Category: Feature toggle 😎

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

@dacook

This comment was marked as outdated.

@mariocarabotta
Copy link
Collaborator

mariocarabotta commented Jun 7, 2023

  • odd/even table rows used to have different background colours, now they are all white > tweaking the spacing between row should fix readability on this
  • pagination buttons are now white with barely any border > I think this is aligned with the new style of pagination, should be ok
  • pagination area used to be white, now it is grey (to accomodate white pagination buttons) > see above
  • base font colour has gone from the old blue to near-black (#191C1D). This changes the font colour inside tables, but also form labels and maybe other things. > this is a good thing. there's really no reason to use blue as a base colour for text
  • Remove uppercasing of form elements and titles. They now appear mostly in sentence case, although I noticed an odd one out. > sentence case is more readable than uppercase (except in very rare occasions), I'll keep an eye on that to see if I spot other ones

@dacook dacook self-assigned this Jun 7, 2023
@dacook

This comment was marked as outdated.

@dacook
Copy link
Member Author

dacook commented Jun 8, 2023

A few more tweaks and let's go!

  • update colour for all headers (change dark blues to "Sherpa blue)
  • also update column header colours
  • increase left border to match
  • fix bottom border

Screen Shot 2023-06-08 at 3 23 59 pm
Screen Shot 2023-06-08 at 3 24 12 pm

@dacook dacook requested a review from jibees June 8, 2023 05:33
@dacook dacook marked this pull request as ready for review June 8, 2023 05:33
Copy link
Contributor

@jibees jibees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Two concerns:

  • I think we should prettier ignore only file, not folder.
  • I'm afraid about resolving conflicts with our PRs ... ;)

.prettierignore Outdated Show resolved Hide resolved
app/webpacker/css/admin_v3/globals/palette.scss Outdated Show resolved Hide resolved
Copy link
Collaborator

@rioug rioug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@rioug
Copy link
Collaborator

rioug commented Jun 12, 2023

Do we need @mariocarabotta review on this as well ?

dacook added 10 commits June 13, 2023 11:44
The current value is 13px already, but I'd like to experiment changing this.

I'm not sure if we even need the reset, but am not delving into that right now.
There is more to do, for example the dropshadows.

I've continued with the unopinionated colour naming (eg color-7), but would like to consider giving them more meaningfule names..
And provide a basic hover state for most other buttons.
The pagination button hover and active states will need updating.

The darker background colour sometimes wraps a whole table (eg products table).
It looks like this is the main font colour in the new designs.
It looks like it’s used in headers, some buttons and a loading message
@dacook
Copy link
Member Author

dacook commented Jun 13, 2023

Thanks, Mario will review further once it has been released and can be reviewed with real-life data.

I've fixed conflicts and will merge once specs pass.

@dacook dacook merged commit c5ce49e into openfoodfoundation:master Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants