-
-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[admin_v3] Update all table styles #10948
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
|
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Two concerns:
- I think we should prettier ignore only file, not folder.
- I'm afraid about resolving conflicts with our PRs ... ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Do we need @mariocarabotta review on this as well ? |
The current value is 13px already, but I'd like to experiment changing this. I'm not sure if we even need the reset, but am not delving into that right now.
There is more to do, for example the dropshadows. I've continued with the unopinionated colour naming (eg color-7), but would like to consider giving them more meaningfule names..
And provide a basic hover state for most other buttons. The pagination button hover and active states will need updating. The darker background colour sometimes wraps a whole table (eg products table).
It looks like this is the main font colour in the new designs.
It looks like it’s used in headers, some buttons and a loading message
Thanks, Mario will review further once it has been released and can be reviewed with real-life data. I've fixed conflicts and will merge once specs pass. |
What? Why?
This updates the general styles for all tables in the admin interface (behind feature toggle), according to the new design.
One example:
More context: while preparing for the new admin product table, I applied some of the new styles across all tables (because we want to do this anyway). I've extracted this from the closed PR.
What should we test?
The style changes are pretty low-risk changes, behind a feature toggle, and will continue to be refined before release, so I think we don't need to test for functionality at this point.
What's changed?
This includes some changes to background/foreground colours, which we might need to resolve before releasing the feature toggle.
Other changes include:
#191C1D
). This changes the font colour inside tables, but also form labels and maybe other things.Release notes
Changelog Category: Feature toggle 😎
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates
master
: https://github.com/openfoodfoundation/openfoodnetwork/wiki/Design-system