Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump view_component from 3.0.0 to 3.1.0 #10918

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 1, 2023

Bumps view_component from 3.0.0 to 3.1.0.

Release notes

Sourced from view_component's releases.

v3.1.0

  • Check defined?(Rails) && Rails.application before using ViewComponent::Base.config.view_component_path.

    Donapieppo

  • Allow customization of polymorphic slot setters.

    Cameron Dutro

  • Fix duplication in configuration docs.

    Tom Chen

  • Fix helpers not reloading in development.

    Jonathan del Strother

  • Add SECURITY.md.

    Joel Hawksley

  • Add Ophelos to list of companies using ViewComponent.

    Graham Rogers

  • Add FlightLogger to list of companies using ViewComponent.

    Joseph Carpenter

  • Fix coverage reports overwriting each other when running locally.

    Jonathan del Strother

  • Add @​reeganviljoen to triage team.

    Reegan Viljoen

Changelog

Sourced from view_component's changelog.

3.1.0

  • Check defined?(Rails) && Rails.application before using ViewComponent::Base.config.view_component_path.

    Donapieppo

  • Allow customization of polymorphic slot setters.

    Cameron Dutro

  • Fix duplication in configuration docs.

    Tom Chen

  • Fix helpers not reloading in development.

    Jonathan del Strother

  • Add SECURITY.md.

    Joel Hawksley

  • Add Ophelos to list of companies using ViewComponent.

    Graham Rogers

  • Add FlightLogger to list of companies using ViewComponent.

    Joseph Carpenter

  • Fix coverage reports overwriting each other when running locally.

    Jonathan del Strother

  • Add @​reeganviljoen to triage team.

    Reegan Viljoen

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies ruby Pull requests that update Ruby code labels Jun 1, 2023
Copy link
Contributor

@jibees jibees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. Wait for a second review.

@jibees
Copy link
Contributor

jibees commented Jun 2, 2023

How to test

Check that the ConfirmModalComponent when removing the image in the white label section is fine. Should be enough.

Bumps [view_component](https://github.com/viewcomponent/view_component) from 3.0.0 to 3.1.0.
- [Release notes](https://github.com/viewcomponent/view_component/releases)
- [Changelog](https://github.com/ViewComponent/view_component/blob/main/docs/CHANGELOG.md)
- [Commits](ViewComponent/view_component@v3.0.0...v3.1.0)

---
updated-dependencies:
- dependency-name: view_component
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@drummer83 drummer83 force-pushed the dependabot/bundler/view_component-3.1.0 branch from b1737b0 to d87e40b Compare June 12, 2023 13:04
@drummer83 drummer83 added the pr-staged-uk staging.openfoodnetwork.org.uk label Jun 12, 2023
@drummer83 drummer83 self-assigned this Jun 12, 2023
@drummer83 drummer83 merged commit 7915189 into master Jun 12, 2023
@drummer83 drummer83 deleted the dependabot/bundler/view_component-3.1.0 branch June 12, 2023 13:36
@drummer83
Copy link
Contributor

Hi @jibees,
Thanks for 'how to test' instructions.
I can confirm, that the modal looks the same before and after staging this PR. 👍
image

Merging! 🚀

@drummer83 drummer83 removed the pr-staged-uk staging.openfoodnetwork.org.uk label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants