-
-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused mini_racer gem #10915
Remove unused mini_racer gem #10915
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If tests pass, it sounds good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
That's not strictly true, we still have a bunch of legacy JS and Angular templates under It might be worth testing this a bit before merging, maybe deploy to staging and check a few bits that use angular templates and maybe try it in the Docker setup if anyone is using that in dev? |
I just tried in normal dev environment changing an AngularJS template and reloading the page. It all updated and I had mini_racer uninstalled completely. |
All asset compilation is done with webpacker at the moment.
Hi @mkllnk, |
What? Why?
All asset compilation is done with webpacker at the moment.
What should we test?
Release notes
Changelog Category: Technical changes
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates