-
-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Invoices] Bulk printing invoices must show error if ABN is required but not set #12373
Comments
…n#12374 and openfoodfoundation#12373 When the invoices feature is deactivated, users should still be able to bulk print or send invoices
…n#12374 and openfoodfoundation#12373 When the invoices feature is deactivated, users should still be able to bulk print or send invoices Adds assertions for bulk invoice actions with empty ABN
@RachL Same question here: Do we want to fix this for the invoices feature toggle off? |
@drummer83 no, I know it's weird, but the deal with instance managers is that we keep letting users print without ABN as long as the invoices are not more compliant (helps those who want to print for packing purposes). However when the toggle gets released, this is needed. |
Description
This should only be fixed under invoice feature toggle
Similar to #12374.
When an instance has the setting "Require an ABN to generate an invoice" ACTIVE, then an error is shown in case an enterprise without ABN tries to generate an invoice. Currently this is only working on the Edit Order page (
/admin/orders/Rxxx/edit
).The exact same error has to be shown as well, if invoices are to be generated on the orders page via bulk action (
/admin/orders
). Currently there is no such error on this page.In case of selected orders of multiple enterprises, no invoice should be printed at all after the error message was shown, even in case some of the enterprises have the ABN set correctly. The error message must be shown for each enterprise with missing ABN or all of the enterprises with missing ABN must be listed in the error message.
The error shall be shown independently from:
Expected Behavior
The error "Enterprise XY must have a valid ABN before invoices can be used." must be shown on the orders page when generating an invoice in case the instance has the setting "Require an ABN to generate an invoice" ACTIVE, and the enterprise has no ABN set.
Actual Behaviour
There is no error when generating an invoice on the orders page while the setting "Require an ABN to generate an invoice" is ACTIVE and the enterprise has no ABN set.
Steps to Reproduce
Make sure this is only done when feature toggle "invoices" is turned ON
/admin/invoice_settings/edit
)./admin/enterprises/<Enterprise xy>/edit#/business_details_panel
). You can also use an existing enterprise and delete the input of the ABN setting.Animated Gif/Screenshot
Instance setting:
Enterprise ABN setting:
Create invoice on Orders page:
Expected error message. It is currently only shown when generating the invoice on the Edit Order page:
Workaround
Severity
bug-s3: a feature is broken but there is a workaround
Your Environment
Possible Fix
The text was updated successfully, but these errors were encountered: