-
-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUU] [Infinite loader] - Remove Stimulus Reflex from Products Page #12331
Comments
Reopenning because we need to finish removing SR and then do a prod test. |
lowering to s2 as this is behind a feature toggle |
Updated the Description to include the remaining action items from #12328 I'm assigning this to myself to work on the remaining items. |
Thanks @chahmedejaz. That would include replacing SR with Turbo, which is actually a pretty big task. We could consider breaking it up, but I suspect it will be necessary to work through it one part at a time anyway. Maybe we can discuss that in Slack. For Edit Image, it's not actually triggering this issue (it doesn't use SR for reloading the products), so we can handle that separately. I do think we should create an issue for it, so will go ahead and create that |
Thanks @dacook for the the heads-up. Edit: |
Thanks for being proactive on this one Ahmed! I've created a separate issue for edit. |
Groan, we missed one more little use of StimulusReflex, I've added a new issue to the list at the top. I'm not sure if this is still an In any case, it's probably a quick fix so I won't spend too much time deliberating it. I've not added any labels to the new sub-issue yet. |
I'm closing this issue: let's keep subissues only. If subissues are a blocker we can raise them as s2, or re-open here if we really have a lot of them and need grouping 👍 . |
In some circumstances, the new bulk edit products screen will fail to load products, leaving an infinite loader, and a poor user wondering if anything was still happening.
Action Items:
Remove SR From:
Steps to reproduce
This was last replicated on fr_prod, at approx 9:30am AEST: #11752 (comment)
Sometimes it works fine, but maybe if the server is busier, it doesn't.
The text was updated successfully, but these errors were encountered: