-
-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUU] Don't reload whole table when cloning products #11987
Comments
if we're viewing 15 per page, we'll see 14 after the action (if deleting), we'll see 16 if cloning. estimate: 1day |
@mariocarabotta @RachL what is the expected behaviour for the pagination info? Asking because this is generated by the backend. |
Hi @anansilva, apologies we have been very light on for details here. Based on previous discussions, I've written some requirements (edit: moved to description at top), but there are still some gaps (as you have identified). TBC:
|
I'll share my thoughts to start with, but Mario or Rachel please confirm what you think.
I think it would be problematic to try and update it, because we're messing with the pagination.
I would suggest a simple slide in (for clone) and slide out (for delete), to avoid the jump which would cause the user to lose their place.
Maybe that would be handy, but I suggest we keep it simple and don't attempt that. Unsaved changes (yellow border) are unsaved until the save button is pressed. Another option is to show a specific warning dialog ("this product has unsaved changes, do you want to submit all changes before cloning?"). But again I don't think we should attempt that. Unsaved changes are simply ignored and not cloned. They are not cleared, so can be saved after the clone is done. |
This comment was marked as resolved.
This comment was marked as resolved.
For reference, the current bulk products screen does update the pagination count when deleting or cloning. See below example where there was a page of 15, and i deleted lots of products: It still says "15 per page" which obviously isn't quite true in this case. But "Viewing 1 to 3" is mostly accurate. Because it's pushing the limits of Reactive Rails (with Turbo), I suggest we first try and solve it with design if possible. But clearly the precedent is there, and I think we could do it if needed. |
Thanks for your comments @dacook, should we split this issue into smaller ones? Here's my suggestion:
|
Thanks Ana. |
This issue is now unassigned and ready to start. Here is a work in progress that might be helpful to refer to: |
When performing a clone from the actions menu, the whole table is reloaded. This can take some time, and is jarring because you can lose your position in a long list of products.
The old products screen does this so we need to support it here too.
Other notes:
For the first iteration, make no changes, this will be re-evaluated later
We'll keep it simple and won't attempt that. As usual, unsaved changes (yellow border) are unsaved until the save button is pressed.
The text was updated successfully, but these errors were encountered: