-
-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUU] Delete a product or variant #11068
Comments
This is adding a new item to the actions menu. It would be worth referring to similar recent PR #11785 For the confirmation popup, I expect we want to use Estimating: in terms of hours I'd think it wouldn't need more than a few. |
Hey @mariocarabotta - I'd love work on this, can you please assign it to me? Thanks. |
@mariocarabotta - Just to confirm, is the display of success and failure messages are being handled in #11517 for this issue as well? |
Ideally yes. the problem is that that card is still in progress. @abdellani probably has quite a few things to work on, it might not be high on his list at the moment. |
# Conflicts: # app/views/admin/products_v3/components/_product_actions.html.haml
# Conflicts: # app/views/admin/products_v3/components/_product_actions.html.haml
# Conflicts: # app/views/admin/products_v3/components/_product_actions.html.haml
Update:
|
# Conflicts: # app/views/admin/products_v3/components/_product_actions.html.haml
Context
This issue builds on top of #11069, to allow to delete products and variants.
Description
- As an: enterprise user
- On page:
/admin/products
- I want to be able to: delete products or variants
- So that: my catalogue is up to date
Acceptance Criteria & Tests
Scenario 1: Product - delete action
Given that I am seeing products in my catalogue
When I select the actions available for a product
Then I see an option to edit and an option to delete
Scenario 2: Product - start deleting
Given that I am seeing the actions for a product
When I select the delete option
Then I see a dialog asking for confirmation
Scenario 3: Product - keep product
Given that I am seeing the delete confirmation dialog
When I select the option to keep the product
Then the dialog disappears
And the product remains in my catalogue
Scenario 4: Product - confirm deleting
Given that I am seeing the delete confirmation dialog
When I select the option to delete the product
Then the deleting process starts
And the dialog disappears
And I see a loading indicator
Scenario 5: Product - delete successful
Given that I have started the deleting process for a product
When the process is successful
Then my catalogue reloads
And I don't see that product anymore
And I see a success message
Scenario 6: Deleting failed
Note: not sure how to handle this failure. We can look into it during development.
Scenario 7: Variant - actions not available
Given that I am seeing products in my catalogue
And I have products with one variant only
The single variant for a product does not show any action
Scenario 8: Variant - actions available
Given that I am seeing products in my catalogue
And I have products with multiple variants
Then those variants have actions
Scenario 9: Variant - delete action
Given that I am seeing products with multiple variants in my catalogue
When I select the actions available for those variants
Then I see an option to delete
Scenario 10: Variant - start deleting
Given that I am seeing the actions for a variant
When I select the delete option
Then I see a dialog asking for confirmation
Scenario 11: Variant - keep variant
Given that I am seeing the delete confirmation dialog
When I select the option to keep the variant
Then the dialog disappears
And the variant remains in my catalogue
Scenario 12: Variant - confirm deleting
Given that I am seeing the delete confirmation dialog
When I select the option to delete the variant
Then the deleting process starts
And the dialog disappears
And I see a loading indicator
Scenario 13: Variant - delete successful
Given that I have started the deleting process for a variant
When the process is successful
Then my catalogue reloads
And I don't see that variant anymore
And I see a success message
Scenario 14: Deleting failed
Note: not sure how to handle this failure. We can look into it during development.
Design specs
Figma screens are available here >
https://www.figma.com/file/v1zbrWDZSRd3Nqoe0SJ2Sm/Engineering-Delivery---Back-Office?type=design&node-id=517%3A2906&mode=design&t=PzBG8cWoBQnyy30t-1
Prototype here (delete first product) > https://www.figma.com/proto/v1zbrWDZSRd3Nqoe0SJ2Sm/Engineering-Delivery---Back-Office?page-id=517%3A2906&type=design&node-id=517-2920&viewport=606%2C258%2C0.08&t=olIZaV9DfNiQk84y-1&scaling=min-zoom&mode=design
The text was updated successfully, but these errors were encountered: