Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flaky] ./spec/system/admin/order_cycles/complex_editing_multiple_product_pages_spec.rb:37 #10027

Closed
Tracked by #8293
filipefurtad0 opened this issue Nov 18, 2022 · 4 comments
Assignees

Comments

@filipefurtad0
Copy link
Contributor

What we should change and why (this is tech debt)

Not yet in master, but seems relevant, non-the less:
rspec ./spec/system/admin/order_cycles/complex_editing_multiple_product_pages_spec.rb:37 #

Failures:

  1) 
    As an administrator
    I want to manage complex order cycles
 editing an order cycle with multiple pages of products select all products
     Failure/Error: page.execute_script("document.getElementById('#{checkbox_id}').scrollIntoView()")
     
     Ferrum::JavaScriptError:
       TypeError: Cannot read properties of null (reading 'scrollIntoView')
           at <anonymous>:1:93
     
     
     [Screenshot Image]: /home/runner/work/openfoodnetwork/openfoodnetwork/tmp/capybara/screenshots/failures_r_spec_example_groups_as_an_administrator_i_want_to_manage_complex_order_cycles_editing_an_order_cycle_with_multiple_pages_of_products_select_all_products_96.png

Context

https://github.com/openfoodfoundation/openfoodnetwork/actions/runs/3496323493/jobs/5854102860

Impact and timeline

@filipefurtad0
Copy link
Contributor Author

This could somehow be related to the knapsack settings, it seems to occur only in this branch:
https://github.com/openfoodfoundation/openfoodnetwork/actions/runs/3514641760/jobs/5888909217

@drummer83
Copy link
Contributor

It's now :38 instead of :37 but I assume this is another occurrence here:
https://github.com/mkllnk/openfoodnetwork/actions/runs/5053925846/jobs/9068278832

@rioug
Copy link
Collaborator

rioug commented Apr 8, 2024

Might be fixed by #12337

@rioug
Copy link
Collaborator

rioug commented Apr 15, 2024

Closing this as #12337 has been merged.

@rioug rioug closed this as completed Apr 15, 2024
sergioosouzaa pushed a commit to sergioosouzaa/openfoodnetwork that referenced this issue Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants