Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we check that if some prices are empty when adding several prices in bulk ? #5435

Open
teolemon opened this issue Jun 22, 2024 · 1 comment
Labels

Comments

@teolemon
Copy link
Member

Problem

Do we check that if some prices are empty when adding several prices in bulk ?
@monsieurtanuki

@monsieurtanuki
Copy link
Contributor

Do we check that if some prices are empty when adding several prices in bulk ?

We certainly do: the paid prices are mandatory - while the not discounted prices are optional.
That means that we couldn't even create the background task with null prices.
There's a check when we press the "send prices!" button, but in that particular case it's a form validation check. That means that for problematic price text fields there will be a red subtitle saying: "this price is mandatory!". Which may not be very explicit if it's price number 2 and we are at price number 9: we would have to scroll to the top to see what's wrong.
UI/UX improvements probably needed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Backlog
Status: 💬 To discuss and validate
Development

No branches or pull requests

2 participants