Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What else required to calculate Nutri-Score #5121

Closed
sineptic opened this issue Mar 20, 2024 · 3 comments · Fixed by #5150
Closed

What else required to calculate Nutri-Score #5121

sineptic opened this issue Mar 20, 2024 · 3 comments · Fixed by #5150
Assignees

Comments

@sineptic
Copy link

Problem

Screenshot_20240320_121828.jpg
app say that some information needed, but not say what I need to add.

Proposed solution

  • add list of what else you need to add
  • underline(or highlight) nutrition values that are required(when adding them)

Additional context

Screenshot_20240320_122421.jpg

Screenshot_20240320_122416.jpg

@monsieurtanuki
Copy link
Contributor

@teolemon Low hanging fruit suggestion: I guess that nutriscore-related nutrients don't change very often, so we could hard-code them and highlight them in the nutrition fact page, possibly with a "needed for nutriscore" subtitle.

@monsieurtanuki monsieurtanuki self-assigned this Apr 11, 2024
@monsieurtanuki monsieurtanuki added the 🐛 bug Something isn't working label Apr 11, 2024
@monsieurtanuki
Copy link
Contributor

Several remarks...

Nutrition fields needed for the nutriscore computation

(as interpreted in compute_nutriscore_score_2023 @ Nutriscore.pm)

  • energy
  • sugars
  • saturated_fat
  • fat
  • salt
  • fiber
  • proteins
  • (computed from ingredients: fruits_vegetables_legumes)

=> a solution to fix the issue would be to systematically consider those fields as part of the nutrition facts edit screen.

More relevant choice of nutrients to display

For historical (good) reasons, starting from the European version of nutrient hierarchy, we decided to display a specific set of nutrients: all those with "important": true. But we could as well use "display_in_edit_form": true, which is slightly the same.
But it's not the same for Russia or Canada:

count Europe Russia Canada
display_in_edit_form 11 11 16
important 10 5 4

=> a solution to fix the issue would be to consider "display_in_edit_form": true instead of "important": true:

  • we would be consistent with the website regarding the initial nutrients suggested as editable
  • those additional nutrients include all the nutrients needed for the nutriscore

Unfortunate discrepancies with the website

For some reason

  • for some products, on the website the "alcool" is there but not editable. A matter of food category? In Smoothie we have no way to know in which case we should "disable" this or this nutrient.
  • in Canada, some nutrient values are in "% DV" by default on the website (and IRL), but unfortunately
    • we don't support "% DV" in off-dart or Smoothie
    • we don't know which nutrients are "% DV"able (same with unit IU)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants