Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adjusting Search History Keyword Tapping #5113

Merged

Conversation

gmmoraes
Copy link
Contributor

@gmmoraes gmmoraes commented Mar 10, 2024

What

  • Changed the way that onTap is called. Alternatively, we could also change to onTap: onTap,

Screenshot

Before:

search_history.mov

After:

Screen.Recording.2024-03-10.at.16.25.27.mov

Fixes Bug(s)

@gmmoraes gmmoraes requested a review from a team as a code owner March 10, 2024 19:26
@github-actions github-actions bot added the 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… label Mar 10, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 9.53%. Comparing base (4d9c7fc) to head (a1b6d9d).
Report is 46 commits behind head on develop.

Files Patch % Lines
...smooth_app/lib/pages/scan/search_history_view.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5113      +/-   ##
==========================================
- Coverage     9.54%   9.53%   -0.02%     
==========================================
  Files          325     327       +2     
  Lines        16411   16529     +118     
==========================================
+ Hits          1567    1576       +9     
- Misses       14844   14953     +109     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@monsieurtanuki monsieurtanuki linked an issue Mar 11, 2024 that may be closed by this pull request
Copy link
Contributor

@monsieurtanuki monsieurtanuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @gmmoraes, looks good to me!

@monsieurtanuki monsieurtanuki merged commit f57c0c0 into openfoodfacts:develop Mar 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion…
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search History Keyword Tapping Doesn't work
3 participants