-
-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 4674 - immediate access to "other" pictures if possible #4928
feat: 4674 - immediate access to "other" pictures if possible #4928
Conversation
New file: * `background_task_product_change.dart`: Interface for background tasks that change a product. Impacted files: * `background_task_crop.dart`: minor refactoring * `background_task_details.dart`: minor refactoring, implementing new interface `BackgroundTaskProductChange` * `background_task_image.dart`: minor refactoring * `background_task_unselected.dart`: minor refactoring, implementing new interface `BackgroundTaskProductChange` * `background_task_upload.dart`: minor refactoring, implementing new interface `BackgroundTaskProductChange` * `product_cards_helper.dart`: new method `getRawProductImages` * `product_image_gallery_other_view.dart`: now we may have directly the raw images, and if needed we refresh the product instead of fetching specific image ids * `product_image_gallery_view.dart`: minor refactoring * `product_image_other_page.dart`: replaced deprecated method * `product_image_server_button.dart`: now we may have directly the raw images, and if needed we refresh the product instead of fetching specific image ids * `product_image_viewer.dart`: replaced deprecated method * `pubspec.lock`: generated * `pubspec.yaml`: upgraded to off-dart 3.3.0 * `uploaded_image_gallery.dart`: now using `List<ProductImage>` as input
For the record we need this PR to be merged in order to implement new features for the prices API. It's using off-dart 3.3.0, which has changes that triggers lint warnings. |
@g123k @M123-dev @AshAman999 Could you have a look at this one ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks about right, thanks @monsieurtanuki
Thank you @M123-dev for your review! Possible impact as there are many "raw" images and they are stored in a verbose mode. |
What
Fixes bug(s)
Part of
Files
New file:
background_task_product_change.dart
: Interface for background tasks that change a product.Impacted files:
background_task_crop.dart
: minor refactoringbackground_task_details.dart
: minor refactoring, implementing new interfaceBackgroundTaskProductChange
background_task_image.dart
: minor refactoringbackground_task_unselected.dart
: minor refactoring, implementing new interfaceBackgroundTaskProductChange
background_task_upload.dart
: minor refactoring, implementing new interfaceBackgroundTaskProductChange
product_cards_helper.dart
: new methodgetRawProductImages
product_image_gallery_other_view.dart
: now we may have directly the raw images, and if needed we refresh the product instead of fetching specific image idsproduct_image_gallery_view.dart
: minor refactoringproduct_image_other_page.dart
: replaced deprecated methodproduct_image_server_button.dart
: now we may have directly the raw images, and if needed we refresh the product instead of fetching specific image idsproduct_image_viewer.dart
: replaced deprecated methodpubspec.lock
: generatedpubspec.yaml
: upgraded to off-dart 3.3.0uploaded_image_gallery.dart
: now usingList<ProductImage>
as input