Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 4549 - correct "forgot password" checks #4558

Merged
merged 2 commits into from
Aug 16, 2023

Conversation

monsieurtanuki
Copy link
Contributor

What

  • The checks of the returned status of "resetPassword" were flawed, as they compared a Status to an int.
  • This is fixed now.
  • We still have a problem on the off-dart side, as we compute the status code from the content of the message. That was OK as long as we stayed in English, that's not possible anymore with the localization (localized emails) recently introduced.

Screenshot

with country + language without country nor language
Screenshot_2023-08-16-12-21-46 Screenshot_2023-08-16-12-34-33

Part of

Impacted file

  • forgot_password_page.dart: corrected the checks.

Impacted file:
* `forgot_password_page.dart`: corrected the checks.
@monsieurtanuki monsieurtanuki requested a review from a team as a code owner August 16, 2023 10:46
@github-actions github-actions bot added the 👥 User management Account login, signup, signout label Aug 16, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2023

Codecov Report

Merging #4558 (af985ca) into develop (e265e75) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##           develop    #4558   +/-   ##
========================================
  Coverage    10.35%   10.35%           
========================================
  Files          296      296           
  Lines        15333    15332    -1     
========================================
  Hits          1587     1587           
+ Misses       13746    13745    -1     
Files Changed Coverage Δ
...ib/pages/user_management/forgot_password_page.dart 62.96% <0.00%> (+0.76%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@monsieurtanuki monsieurtanuki merged commit 524dd04 into openfoodfacts:develop Aug 16, 2023
6 checks passed
@monsieurtanuki
Copy link
Contributor Author

Thank you @g123k for your review.

Today I'll PR in off-dart in order to fix completely the issue.

@g123k
Copy link
Collaborator

g123k commented Aug 16, 2023

Thank you @g123k for your review.

Today I'll PR in off-dart in order to fix completely the issue.

+1 my fix, was only to have something better for the release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👥 User management Account login, signup, signout
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants