Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: A nice animation for the onboarding #4311

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jul 14, 2023

Hi everyone,

I have tried what we can do with Rive and the gyroscope tonight.
For example, the onboarding, could be way less static than today.

First, the sun is an animation from Rive.
And second, have a look at hills, where they move as I shake my device (thanks to the gyroscope).

Here is a video: https://github.com/openfoodfacts/smooth-app/assets/246838/e3e20b63-9e92-4ca0-bb8b-4e0685cd075d

I don't know if it's worth a merge, but clearly, that is the kind of small thing we can do to make the app more friendly.

@g123k g123k added the 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… label Jul 14, 2023
@g123k g123k requested a review from a team as a code owner July 14, 2023 21:10
@g123k g123k self-assigned this Jul 14, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #4311 (ee7f999) into develop (1cd22a6) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #4311      +/-   ##
===========================================
- Coverage    10.80%   10.77%   -0.03%     
===========================================
  Files          287      287              
  Lines        14202    14235      +33     
===========================================
  Hits          1534     1534              
- Misses       12668    12701      +33     
Impacted Files Coverage Δ
...oth_app/lib/pages/onboarding/reinvention_page.dart 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@teolemon
Copy link
Member

The hills, how shall I put it ? 🍑

@g123k
Copy link
Collaborator Author

g123k commented Jul 17, 2023

The hills, how shall I put it ? 🍑

I'm shocked, you have one of those sick minds 🙀

@M123-dev M123-dev merged commit 8e80d42 into openfoodfacts:develop Jul 20, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android dependencies 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score…
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants