Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ensure we always use a SmoothAppBar #4184

Merged
merged 1 commit into from
Jun 18, 2023
Merged

fix: Ensure we always use a SmoothAppBar #4184

merged 1 commit into from
Jun 18, 2023

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jun 16, 2023

Hi everyone,

To be sure we have a consistent back button on the whole app, I've migrated all AppBar to SmoothAppBar.
This way the iOS app will feel better.

@g123k g123k added 🍎 iOS iOS specific issues or PRs action bars labels Jun 16, 2023
@g123k g123k requested a review from a team as a code owner June 16, 2023 10:36
@g123k g123k self-assigned this Jun 16, 2023
@github-actions github-actions bot added background tasks Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. 🥫 Product page 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… 👥 User management Account login, signup, signout labels Jun 16, 2023
@g123k g123k changed the title fix: Ensure we always use the SmoothAppBar fix: Ensure we always use a SmoothAppBar Jun 16, 2023
teolemon
teolemon approved these changes Jun 16, 2023
View reviewed changes
Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @g123k

@M123-dev M123-dev merged commit 29bdad3 into openfoodfacts:develop Jun 18, 2023
7 checks passed
@github-actions github-actions bot mentioned this pull request Jun 18, 2023
Merged
@g123k g123k deleted the smooth_app_bar branch June 18, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teolemon teolemon teolemon approved these changes

Assignees

@g123k g123k

Labels
action bars background tasks 🍎 iOS iOS specific issues or PRs Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. 🥫 Product page 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… 👥 User management Account login, signup, signout
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@g123k @teolemon @M123-dev