fix: 4056 - fixed List syntax for offline data

[monsieurtanuki]

What

• Fixes a bug about how to modify a List created from an existing const one.

Fixes bug(s)

• Fixes: Downloading or updating offline data don't work anymore #4056

[codecov-commenter]

Codecov Report

Merging #4059 (89e7e4e) into develop (a007367) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #4059      +/-   ##
===========================================
- Coverage    11.00%   10.96%   -0.04%     
===========================================
  Files          270      270              
  Lines        13369    13416      +47     
===========================================
  Hits          1471     1471              
- Misses       11898    11945      +47     

Impacted Files	Coverage Δ
.../smooth_app/lib/query/products_preload_helper.dart	0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[AshAman999]

Looks fine

There's one more place which needs the same change

https://github.com/openfoodfacts/smooth-app/blob/develop/packages/smooth_app/lib/pages/offline_data_page.dart

[monsieurtanuki]

There's one more place which needs the same change

Indeed! I've just committed the additional fix.
Too bad the lint check doesn't detect that error.

[teolemon]

@AshAman999 @monsieurtanuki merging