Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 4032 - better paddings for login page #4037

Merged
merged 3 commits into from
May 28, 2023
Merged

fix: 4032 - better paddings for login page #4037

merged 3 commits into from
May 28, 2023

Conversation

monsieurtanuki
Copy link
Contributor

What

  • Minor changes in the paddings of the login page.

Screenshot

top bottom
Screenshot_2023-05-27-15-13-48 Screenshot_2023-05-27-15-13-55

Fixes bug(s)

@monsieurtanuki monsieurtanuki requested a review from a team as a code owner May 27, 2023 13:18
@github-actions github-actions bot added the 👥 User management Account login, signup, signout label May 27, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 27, 2023 •
edited
Loading

Codecov Report

Merging #4037 (150303e) into develop (e2197d1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #4037   +/-   ##
========================================
  Coverage    10.99%   11.00%           
========================================
  Files          270      270           
  Lines        13368    13369    +1     
========================================
+ Hits          1470     1471    +1     
  Misses       11898    11898
Impacted Files Coverage Δ
...ib/generic_lib/widgets/smooth_text_form_field.dart 87.17% <ø> (ø)
...ooth_app/lib/pages/user_management/login_page.dart 48.82% <100.00%> (+0.30%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@teolemon
Copy link
Member

Can we ensure all the text is legible in the nope field?

@monsieurtanuki
Copy link
Contributor Author

Can we ensure all the text is legible in the nope field?

@teolemon Not sure I get what you mean, as everything is legible in my screenshots. You mean everything packed in a single page without scrolling?

@teolemon
Copy link
Member

Screenshot_20230528-160229.png

@monsieurtanuki
Copy link
Contributor Author

Latest commit; is that OK @teolemon?
Screenshot_2023-05-28-16-11-25

teolemon
teolemon approved these changes May 28, 2023
View reviewed changes
Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @monsieurtanuki 🆗

@teolemon teolemon merged commit c60f2a5 into openfoodfacts:develop May 28, 2023
@github-actions github-actions bot mentioned this pull request May 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teolemon teolemon teolemon approved these changes

Assignees

@monsieurtanuki monsieurtanuki

Labels
goldens 🧪 Tests 👥 User management Account login, signup, signout
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add padding on top in the login screen
3 participants
@monsieurtanuki @codecov-commenter @teolemon