-
-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 3865 Insufficient contrast for the error banner #3940
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heyy @anujchoudhary-17 sorry for my late review, I was busy the last few days. The changes look good. Thanks a lot 😄
Only our automated testing is not happy with the formatting. Could you run dart format .
to fix it.
(Its in line 155 it will split the ),), into two lines) 😅
Hi @M123-dev Sorry this is my first time contributing to Open Source. I have pulled and merged the code and ran that command and pushed it again. Is there anything else I am supposed to do? |
Codecov Report
@@ Coverage Diff @@
## develop #3940 +/- ##
===========================================
- Coverage 11.00% 10.99% -0.01%
===========================================
Files 265 265
Lines 13044 13046 +2
===========================================
Hits 1435 1435
- Misses 11609 11611 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anujchoudhary-17 that is everything needed already. Surprised that it went that well on your first contribution. I was quite confused on my first Pull request 🤣
Yeah, thanks a lot and not only congrats on your first contribution here but first overall 🥳
What
Screenshot
Fixes bug(s)
Part of