-
-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 3042 - saving explicitly product name in the correct language #3862
fix: 3042 - saving explicitly product name in the correct language #3862
Conversation
Impacted files: * `add_basic_details_page.dart`: now setting the product name "in language" * `background_task_details.dart`: added the `lang` to the "save product to server" calls; minor refactoring
Impacted file: * `background_task_details.dart`: added the `lang` to the "save product to server" calls; minor refactoring
Codecov Report
@@ Coverage Diff @@
## develop #3862 +/- ##
===========================================
- Coverage 10.73% 10.73% -0.01%
===========================================
Files 273 273
Lines 13478 13479 +1
===========================================
Hits 1447 1447
- Misses 12031 12032 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should also impact packaging text.
Probably. Something like "whatever text I'm writing is in this language" (at the product level), in addition to the language and country we already define (at the query level). |
But I'm not sure we use packaging text that much any more. We rather use the "new" packaging items, don't we? |
Yes @monsieurtanuki . We however have to ensure image upload selection/deselect/crop is present in the new system (which it isn't) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codewise it looks good to me, though I don't know which side effects could happen when having a just partly multilingual app
Thank you @M123-dev for your review! |
What
lang
field of product is set explicitly for each server update.productName
, we set it just for that language. The other translations are not impacted.ingredients
, but I haven't double-checked yet.Fixes bug(s)